Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse doubly-encoded records #27

Open
coldacid opened this issue Jan 31, 2022 · 3 comments
Open

Parse doubly-encoded records #27

coldacid opened this issue Jan 31, 2022 · 3 comments

Comments

@coldacid
Copy link
Contributor

See satoshisstream/satoshis.stream#22 and valcanobacon/BoostCLI#4 for background.

If the podcast custom record is still encoded after decoding, give it a second round of decoding so that apps which mistakenly double-encode the record will still work with Helipad.

@valcanobacon
Copy link
Contributor

Fixed BoostCLI valcanobacon/BoostCLI@2c30eee

@daveajones
Copy link
Contributor

I’d rather just reach out to the sending tool’s author and let them know to fix it as in this case. Trying to anticipate all the possible ways that an HTLC can contain miscoded information seems like a rough go.

@coldacid
Copy link
Contributor Author

coldacid commented Feb 1, 2022

@daveajones well we're working on that already, per #27 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants