Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Folders #81

Merged
merged 66 commits into from
Aug 9, 2022
Merged

feat: Folders #81

merged 66 commits into from
Aug 9, 2022

Conversation

RezaRahemtola
Copy link
Member

@RezaRahemtola RezaRahemtola commented Jul 14, 2022 •
edited
Loading

Description

Folder implementation in the storage part.
Ability to:

  • Create folders
  • Path navigation
  • Move files in folders
  • Move folders (and their content)
  • Delete folders (and also files in it)
  • Rename folders

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

All current files won‘t be displayed anymore due to their missing props related to paths.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@RezaRahemtola RezaRahemtola added the enhancement New feature or request label Jul 14, 2022
@RezaRahemtola RezaRahemtola added this to the Storage - Folders milestone Jul 14, 2022
lucas-louis
lucas-louis approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@lucas-louis lucas-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RezaRahemtola RezaRahemtola marked this pull request as ready for review August 9, 2022 16:22
@RezaRahemtola RezaRahemtola merged commit 46086d3 into dev Aug 9, 2022
@RezaRahemtola RezaRahemtola deleted the feat/folders branch August 9, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-louis lucas-louis lucas-louis approved these changes

@adrienfort adrienfort Awaiting requested review from adrienfort

Assignees

@RezaRahemtola RezaRahemtola

@MizuriGit MizuriGit

@Samoten777 Samoten777

Labels
enhancement New feature or request
Projects
None yet
Milestone
Storage - Folders
Development

Successfully merging this pull request may close these issues.
7 participants
@RezaRahemtola @lucas-louis @MizuriGit @Samoten777 @adrienfort @Alex-Prevot @ZerLock