Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dashboard UI refactor #121

Merged
merged 54 commits into from
Mar 2, 2023
Merged

feat: dashboard UI refactor #121

merged 54 commits into from
Mar 2, 2023

Conversation

lucas-louis
Copy link
Member

Description

Update dashboard UI pages:

  • New navigation bar
  • New drive page
  • New shared drive page
  • New programs page
  • New contacts page
  • New trash page
  • New account page

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

All the files are now into the drive folder => /drive for the endpoint
Add dynamic tab item
Add this dependency to manage random profile avatar
When the class is construct, the account variable is set thanks to the constructor.
Only an available account (not undefined) can be passed into this constructor so the account bariable can't be undefined.
Remove this feature due to display bug
@lucas-louis lucas-louis added the enhancement New feature or request label Feb 24, 2023
@lucas-louis lucas-louis self-assigned this Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for nimble-praline-605cf6 ready!

Name Link
🔨 Latest commit 38d5441
🔍 Latest deploy log https://app.netlify.com/sites/nimble-praline-605cf6/deploys/63f8fbc6b3871b000854dc87
😎 Deploy Preview https://deploy-preview-121--nimble-praline-605cf6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for soft-pixie-bff6c5 failed.

Name Link
🔨 Latest commit 38d5441
🔍 Latest deploy log https://app.netlify.com/sites/soft-pixie-bff6c5/deploys/63f8fbc62a26a70008f75fb3

@lucas-louis lucas-louis changed the base branch from master to dev February 24, 2023 18:03
@lucas-louis lucas-louis linked an issue Feb 24, 2023 that may be closed by this pull request
2 tasks
Comment on lines 21 to 23
import getFileType from '../../../utils/getFileType';
import formatDate from '../../../utils/formatDate';
import formatFileSize from '../../../utils/formatFileSize';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import getFileType from '../../../utils/getFileType';
import formatDate from '../../../utils/formatDate';
import formatFileSize from '../../../utils/formatFileSize';
import getFileType from './utils/getFileType';
import formatDate from './utils/formatDate';
import formatFileSize from './utils/formatFileSize';

should work as we have set a baseSrc in tsconfig.json

// </Tabs>
// </VStack>
// </VStack>
// );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this if it's not used 😄

import { useState } from 'react';
import { BsFillFilePersonFill } from 'react-icons/bs';

import { IPCContact } from 'types/types';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { IPCContact } from 'types/types';
import type { IPCContact } from 'types/types';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

import { useState } from 'react';
import { BsFileEarmarkFill } from 'react-icons/bs';

import { IPCFile } from 'types/types';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { IPCFile } from 'types/types';
import type { IPCFile } from 'types/types';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

@RezaRahemtola RezaRahemtola linked an issue Mar 2, 2023 that may be closed by this pull request
3 tasks
@RezaRahemtola RezaRahemtola merged commit b4e8305 into dev Mar 2, 2023
@RezaRahemtola RezaRahemtola deleted the feat/dashboard-UI-refactor branch March 2, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Uniformize the modals [Feature]: Refactor the Computing frontend
2 participants