Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incomplete github repositories list into modal #117

Merged
merged 2 commits into from
Jan 7, 2023
Merged

fix: incomplete github repositories list into modal #117

merged 2 commits into from
Jan 7, 2023

Conversation

lucas-louis
Copy link
Member

Description

  • Add multi pages management
  • Update frontend to display multi pages

Close #91

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@lucas-louis lucas-louis added the bug Something isn't working label Jan 3, 2023
@lucas-louis lucas-louis self-assigned this Jan 3, 2023
@lucas-louis lucas-louis linked an issue Jan 3, 2023 that may be closed by this pull request
[Bug]: Incomplete GitHub repositories list #91
Closed
RezaRahemtola
RezaRahemtola approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool 🔥

It could be even better with a search bar instead of the page switch / select, for example in my case I have 8 pages which is quite unpleasant to navigate 😉

src/components/computing/github/GithubModal.tsx Show resolved Hide resolved
@RezaRahemtola RezaRahemtola merged commit c368467 into dev Jan 7, 2023
@RezaRahemtola RezaRahemtola deleted the fix/github-repo-list branch January 7, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RezaRahemtola RezaRahemtola RezaRahemtola approved these changes

Assignees

@lucas-louis lucas-louis

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 5 - Computing refactoring
Development

Successfully merging this pull request may close these issues.

[Bug]: Incomplete GitHub repositories list
2 participants
@lucas-louis @RezaRahemtola