Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement a soft delete with a bin #106

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Feat: Implement a soft delete with a bin #106

merged 6 commits into from
Nov 25, 2022

Conversation

EdenComp
Copy link
Contributor

Description

This PR adds a "soft delete" feature, which allow users to move files to the bin and either restore them or permanently delete them.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

  • Adds a button "Move file/folder to bin" to their respective edition
  • Auto deletes files from the bin when the user connects (configurable amount of days)

@RezaRahemtola RezaRahemtola linked an issue Nov 18, 2022 that may be closed by this pull request
3 tasks
@EdenComp EdenComp marked this pull request as ready for review November 24, 2022 18:32
@RezaRahemtola RezaRahemtola merged commit 434c5eb into dev Nov 25, 2022
@RezaRahemtola RezaRahemtola deleted the feat/bin branch November 25, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement a soft delete for files & folders
3 participants