Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): watch for geonature_config.toml changes when dev_back running #3316

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jacquesfize
Copy link
Contributor

This PR propose to change geonature dev_back commands so it restart the flask service when the geonature_config.toml is edited

@camillemonchicourt
Copy link
Member

And why not other config files in the same directory ?

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (c5443bc) to head (48cd684).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
backend/geonature/core/command/main.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3316   +/-   ##
========================================
  Coverage    83.94%   83.95%           
========================================
  Files          122      122           
  Lines         9719     9721    +2     
========================================
+ Hits          8159     8161    +2     
  Misses        1560     1560           
Flag Coverage Δ
pytest 83.95% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacquesfize
Copy link
Contributor Author

And why not other config files in the same directory ?

indeed !

@jacquesfize jacquesfize merged commit 19010fa into develop Jan 13, 2025
8 of 9 checks passed
@jacquesfize jacquesfize deleted the feat/extend-dev-back branch January 13, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants