-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to turn off NC and ambient sound #36
Conversation
Hey I might be wrong on this one, but to me it looks like |
Just tested here and turns off on a XM4 too. That's weird; both approaches turns it off (independently or combined). Taking another look at bluetooth messages between my phone and xm4, apparently both informations are sent ( |
I have updated the macOS version to have the same functionality. |
@guilhermealbm which method did you use to fetch the messages between your phone and the headset? Did you hook the relevant function using Frida or something? I didn't manage to get it to work using the sniffer Android provides. I'll probably merge this this weekend, BTW. |
Hi @Plutoberth! I started trying logging with Bluetooth HCI Snoop and analyzing it with Wireshark, but was extremely confusing. So, I discovered that my device has a logkit. It generates a really big file, but I filtered by my XM4's MAC and found the event logs;
I ommited my mac addr, but, in general, that's it! 😃 |
Wow, so this format is standardized? I was 100% sure it was proprietary. This is really great news for future features. I have a Oneplus too so I'll check this out when I have some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a standardized format. Fortunately, toggling NC button also calls android's I was not sure why this happens too, but Galaxy Buds Client explains it very well. To certain features, reverse-engineer the data format is the only alternative. |
LGTM, merged :) |
This fixes #18. After taking a look over bluetooth messages, found out that ambient sound control is turned off when sending vol=-1.
The only problem I faced is when checking and, after, unchecking the box. It returns a "Invalid checksum!". Same happens when do it at "Focus on Voice" checkbox, so I think that's maybe a problem with XM4's (and not my changes), as other people said in #27.
I tested it in XM4's and Windows. Hope it helps! :)