Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table.slice & table.countvalues #958

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Add table.slice & table.countvalues #958

merged 2 commits into from
Sep 23, 2024

Conversation

well-in-that-case
Copy link
Member

@well-in-that-case well-in-that-case commented Sep 23, 2024 •
edited
Loading

table.slice mimics the semantics of string.sub. (so it supports negative indices and whatnot)

Closes #955
Closes #553

@Sainan
Copy link
Member

Sainan commented Sep 23, 2024

I do understand the reason for calling it sub, but I think it's generally more understandable to say "slice" when it comes to arrays, whereas in strings "substring" is more commonplace.

@well-in-that-case well-in-that-case changed the title Add table.sub & table.countvalues Add table.slice & table.countvalues Sep 23, 2024
@Sainan
Copy link
Member

Sainan commented Sep 23, 2024

Otherwise LGTM

@well-in-that-case well-in-that-case merged commit 298871e into 0.10.0 Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@well-in-that-case @Sainan