forked from kptfh/feign-reactive
-
Notifications
You must be signed in to change notification settings - Fork 129
Implement tests for ContentType and FormUtils #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Periecle
wants to merge
2
commits into
develop
Choose a base branch
from
implement-content-type-form-utils-tests-3112091859909603494
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 60 additions & 1 deletion
61
feign-reactor-core/src/test/java/reactivefeign/utils/FormUtilsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,65 @@ | ||
| package reactivefeign.utils; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.Arrays; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class FormUtilsTest { | ||
|
|
||
| //TODO | ||
| @Test | ||
| public void shouldSerializeSimpleForm() { | ||
| Map<String, Object> form = new LinkedHashMap<>(); | ||
| form.put("key1", "value1"); | ||
| form.put("key2", "value2"); | ||
|
|
||
| SerializedFormData serialized = FormUtils.serializeForm(form, StandardCharsets.UTF_8); | ||
|
|
||
| assertThat(serialized.getFormDataString()).isEqualTo("key1=value1&key2=value2"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldSerializeFormWithCollection() { | ||
| Map<String, Object> form = new LinkedHashMap<>(); | ||
| form.put("key", Arrays.asList("value1", "value2")); | ||
|
|
||
| SerializedFormData serialized = FormUtils.serializeForm(form, StandardCharsets.UTF_8); | ||
|
|
||
| assertThat(serialized.getFormDataString()).isEqualTo("key=value1&key=value2"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldSerializeFormWithSpecialCharacters() { | ||
| Map<String, Object> form = new LinkedHashMap<>(); | ||
| form.put("key ", "value&"); | ||
|
|
||
| SerializedFormData serialized = FormUtils.serializeForm(form, StandardCharsets.UTF_8); | ||
|
|
||
| assertThat(serialized.getFormDataString()).isEqualTo("key+=value%26"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldSerializeFormWithNullValue() { | ||
| Map<String, Object> form = new LinkedHashMap<>(); | ||
| form.put("key", null); | ||
|
|
||
| SerializedFormData serialized = FormUtils.serializeForm(form, StandardCharsets.UTF_8); | ||
|
|
||
| assertThat(serialized.getFormDataString()).isEqualTo("key"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldSerializeFormWithDifferentCharset() { | ||
| Map<String, Object> form = new LinkedHashMap<>(); | ||
| form.put("key", "value"); | ||
|
|
||
| SerializedFormData serialized = FormUtils.serializeForm(form, StandardCharsets.ISO_8859_1); | ||
|
|
||
| assertThat(serialized.getFormDataString()).isEqualTo("key=value"); | ||
| assertThat(serialized.getFormData()).isEqualTo(StandardCharsets.ISO_8859_1.encode("key=value")); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated regular expression is a definite improvement for handling quoted charsets. However, it could be made more robust. According to RFC 2616, the
?character is a separator and should not be part of the charset value. The current regex might incorrectly include it in the captured charset name.To handle this correctly, I suggest adding
?to the negated character class in the capturing group. This will ensure that?acts as a delimiter for the charset value.