Limit max polling rate #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMoonThatRises
approved these changes
May 25, 2024
|
PlayCover/PlayCover#1022 per se is not fixed by the rate limiter, as it can still be replicated by spamming the scrolling wheel. |
Depal1
approved these changes
Jun 2, 2024
It's because the rate limit is put on mouse moved event, not including scroll wheel event. Maybe I should change it to limiting them both. |
I just found that PlayCover/PlayCover#1022 is not a matter of polling rate. So I will open another PR to fix it. This PR is OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some Wuthering Waves pointer issue
Previously, playcover would deliver a touch event to the game whenever a mouse event arrives. However, some mouses have poll rate over 1000 which is far beyond the designed processing ability of a touchscreen game.
In this PR, a swipe action's polling rate is limited to no more than 125, so as to fix some issues caused by high polling rate.
This might also fix PlayCover/PlayCover/issues/1483, in such a case: that the touching system is overwhelmed by too many move events, and the system decides to randomly drop some events, and eventually drops a touch_end event. If people are reporting it only on mouse but not touchpad, that could be this case.
Personally I'm playing with a touchpad and everything works perfectly. I don't have a working mouse so I can't say for sure if it's actually fixed. Someone if you have that issue please help me test thx.