Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully disables input mapping when typing #112

Merged
merged 2 commits into from
May 8, 2023

Conversation

XuYicong
Copy link
Member

@XuYicong XuYicong commented May 7, 2023

Fix issues that if any mapped key is held while entering typing mode, the touch point would not release even if the key is released.

In the original design, only keyboard mapping is disabled when typing.
This PR would also disable mouse and controller mapping, so that it could conveniently release all touch points.

Steps to reproduce the issue in Genshin:

  1. Hold any key mapped but not on UI elements, say F
  2. Click an input box to enter typing mode
  3. Release F
  4. Press Enter or Esc to exit typing mode
  5. Hide cursor and move mouse. Now the expected behaviour is that camera moves, but the actual behaviour is that camera zooms.

Besides, this PR renames corresponding notification names from KeymappingEnable/Disable to CursorHide/Show to match the actual behaviour.

@IsaacMarovitz IsaacMarovitz changed the base branch from 3.0.0-staging to master May 7, 2023 21:36
@IsaacMarovitz IsaacMarovitz changed the base branch from master to 3.0.0-staging May 8, 2023 01:31
@JoseMoreville JoseMoreville merged commit b07d385 into PlayCover:3.0.0-staging May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants