Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when debug does not contain prefiltered gyro data #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Mar 14, 2019

  1. set default scaling equal across all noise plots

    set default scaling equal across all noise plots.
    bw1129 committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    ad889d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Update PID-Analyzer.py

    bw1129 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    68f97ed View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. display warning for incorrect debug_mode

    I'd like to propose that the debug noise plots display a warning if the debug variable does not contain prefiltered gyro data. This would help avoid the confusion some people have when they have unknowingly selected the incorrect debug_mode in Betaflight, resulting in meaningless results in the debug subplots. An easy way to do this is to code when the 4th column of debug[3] is not empty indicating debug variable does not contain prefiltered gyro data. We could consider using debug_mode variable itself, but this wont work for certain earlier versions of BF. The solution I propose here involves 2 simple lines of code, the first (line 703) checks to see if debug[3] contains data (indicating incorrect debug_mode, since 4th column should be empty otherwise), and the second is a conditional statement (line 470) for presenting warning overlaid on debug subplots. There might be a more elegant way to do this, but this works.
    bw1129 committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    fb6a240 View commit details
    Browse the repository at this point in the history
  2. Update PID-Analyzer.py

    bw1129 committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    20ddf7e View commit details
    Browse the repository at this point in the history
  3. warning when debug does not contain prefiltered gyro data

    I'd like to propose that the debug noise plots display a warning if the debug variable does not contain prefiltered gyro data. This would help avoid the confusion some people have when they have unknowingly selected the incorrect debug_mode in Betaflight, resulting in meaningless results in the debug subplots. An easy way to do this is to code when the 4th column of debug[3] is not empty indicating debug variable does not contain prefiltered gyro data. We could consider using debug_mode variable itself, but this wont work for certain earlier versions of BF. The solution I propose here involves 2 simple lines of code, the first (line 703) checks to see if debug[3] contains data (indicating incorrect debug_mode, since 4th column should be empty otherwise), and the second is a conditional statement (line 470) for presenting warning overlaid on debug subplots. There might be a more elegant way to do this, but this works.
    bw1129 committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    01ba23f View commit details
    Browse the repository at this point in the history