Run Unmarked Test pre-commit only if all other hooks pass #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanici
commented
Oct 30, 2024
| @@ -3,6 +3,7 @@ repos: | |||
| rev: 24.3.0 | |||
| hooks: | |||
| - id: black-jupyter | |||
| log_file: devtools/pre-commit.log | |||
There was a problem hiding this comment.
logs are created only when a pre-commit hook fails
There was a problem hiding this comment.
if it fails on the first pass, the run again does it delete the old log file? or does it just overwrite it with a blank one?
There was a problem hiding this comment.
I think the last one deletes it at the end of each run.
There was a problem hiding this comment.
yea it makes sure its deleted after every run
dpanici
requested review from
a team,
rahulgaur104,
f0uriest,
ddudt,
kianorr,
sinaatalay,
unalmis and
YigitElma
and removed request for
a team
YigitElma
reviewed
Oct 30, 2024
YigitElma
previously approved these changes
Oct 30, 2024
Co-authored-by: Yigit Gunsur Elmacioglu <[email protected]>
YigitElma
approved these changes
Oct 30, 2024
YigitElma
changed the title
f0uriest
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the unmarked test pre-commit hook (at least on my laptop) can take anywhere from 5-10 seconds to run, so I'd rather it only run if everything else is passing.