-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in PlasmaVesselDistance signed distance error checks #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grids have differing number of zeta points, which causes np.allclose to error out insteadof hte correct error passing
dpanici
requested review from
a team,
rahulgaur104,
f0uriest,
ddudt,
kianorr,
sinaatalay,
unalmis and
YigitElma
and removed request for
a team
October 27, 2024 05:22
Can this be the longest branch name lol |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 96 96
Lines 24006 24007 +1
=======================================
+ Hits 22930 22931 +1
Misses 1076 1076
|
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_midres | +2.52 +/- 3.68 | +1.53e-02 +/- 2.22e-02 | 6.20e-01 +/- 1.4e-02 | 6.05e-01 +/- 1.7e-02 |
test_build_transform_fft_highres | +1.33 +/- 3.12 | +1.32e-02 +/- 3.11e-02 | 1.01e+00 +/- 1.3e-02 | 9.97e-01 +/- 2.8e-02 |
test_equilibrium_init_lowres | +2.51 +/- 1.69 | +9.52e-02 +/- 6.44e-02 | 3.90e+00 +/- 4.6e-02 | 3.80e+00 +/- 4.5e-02 |
test_objective_compile_atf | +1.11 +/- 4.21 | +8.65e-02 +/- 3.28e-01 | 7.89e+00 +/- 2.2e-01 | 7.80e+00 +/- 2.4e-01 |
test_objective_compute_atf | +1.04 +/- 2.86 | +1.08e-04 +/- 2.96e-04 | 1.05e-02 +/- 1.9e-04 | 1.04e-02 +/- 2.3e-04 |
test_objective_jac_atf | -0.95 +/- 3.57 | -1.80e-02 +/- 6.75e-02 | 1.87e+00 +/- 4.4e-02 | 1.89e+00 +/- 5.2e-02 |
test_perturb_1 | +1.19 +/- 1.43 | +1.50e-01 +/- 1.80e-01 | 1.27e+01 +/- 1.4e-01 | 1.26e+01 +/- 1.2e-01 |
test_proximal_jac_atf | -0.53 +/- 1.13 | -4.24e-02 +/- 9.09e-02 | 8.03e+00 +/- 5.9e-02 | 8.07e+00 +/- 6.9e-02 |
test_proximal_freeb_compute | +0.81 +/- 0.86 | +1.48e-03 +/- 1.56e-03 | 1.84e-01 +/- 1.0e-03 | 1.82e-01 +/- 1.2e-03 |
test_build_transform_fft_lowres | +0.24 +/- 3.75 | +1.26e-03 +/- 1.93e-02 | 5.16e-01 +/- 1.0e-02 | 5.15e-01 +/- 1.7e-02 |
test_equilibrium_init_medres | +0.24 +/- 0.99 | +9.57e-03 +/- 4.02e-02 | 4.07e+00 +/- 3.0e-02 | 4.06e+00 +/- 2.6e-02 |
test_equilibrium_init_highres | -0.17 +/- 0.91 | -9.23e-03 +/- 4.90e-02 | 5.39e+00 +/- 4.1e-02 | 5.40e+00 +/- 2.7e-02 |
test_objective_compile_dshape_current | +0.49 +/- 1.59 | +1.87e-02 +/- 6.07e-02 | 3.84e+00 +/- 4.4e-02 | 3.82e+00 +/- 4.2e-02 |
test_objective_compute_dshape_current | -0.31 +/- 1.51 | -1.13e-05 +/- 5.52e-05 | 3.64e-03 +/- 4.0e-05 | 3.65e-03 +/- 3.8e-05 |
test_objective_jac_dshape_current | +0.35 +/- 8.66 | +1.41e-04 +/- 3.52e-03 | 4.08e-02 +/- 2.3e-03 | 4.07e-02 +/- 2.7e-03 |
test_perturb_2 | +0.17 +/- 0.84 | +2.91e-02 +/- 1.46e-01 | 1.73e+01 +/- 1.1e-01 | 1.73e+01 +/- 9.6e-02 |
test_proximal_freeb_jac | -0.08 +/- 1.12 | -6.12e-03 +/- 8.32e-02 | 7.40e+00 +/- 5.3e-02 | 7.41e+00 +/- 6.4e-02 |
test_solve_fixed_iter | +0.56 +/- 58.33 | +2.81e-02 +/- 2.92e+00 | 5.03e+00 +/- 2.1e+00 | 5.00e+00 +/- 2.0e+00 | |
there's no character limit, it's fine. Just approve it |
rahulgaur104
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the grids have differing number of zeta points, np.allclose errors out instead of the correct error passing. This fixes the bug