Skip to content

Feature/donation link qr code#1621

Merged
sagararyal merged 14 commits into
developfrom
feature/donation-link-QR-Code
Feb 23, 2023
Merged

Feature/donation link qr code#1621
sagararyal merged 14 commits into
developfrom
feature/donation-link-QR-Code

Conversation

@Shreyaschorge

Copy link
Copy Markdown
Contributor

#Feature

  • Add QR Code for donation link at route /profile/donation-link
  • QR Code will update as per user's input

@vercel

vercel Bot commented Nov 23, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
planet-webapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 10:05AM (UTC)

@mariahosfeld

Copy link
Copy Markdown
Contributor

Quick first check looks good, but also a download or copy function for the QR-Code needs to be included.

@mariahosfeld

Copy link
Copy Markdown
Contributor

The functionality works for me.
As the explanation for the QR-Code is now at the top, please change the "this" to "the".

@sagararyal

sagararyal commented Nov 25, 2022

Copy link
Copy Markdown
Member

@norbertschuler norbertschuler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Comment thread package.json
@sagararyal sagararyal merged commit 2ef7304 into develop Feb 23, 2023
@sagararyal sagararyal deleted the feature/donation-link-QR-Code branch February 23, 2023 10:51
@mohitb35 mohitb35 mentioned this pull request Feb 23, 2023
Comment on lines +269 to +270
<img
style={{ display: 'block', width: '150px', height: '150px' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid inline styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants