Skip to content

Rework detail screen for sample trees in RO profile#1616

Merged
sagararyal merged 9 commits into
developfrom
feature/rework-details-screen
Feb 23, 2023
Merged

Rework detail screen for sample trees in RO profile#1616
sagararyal merged 9 commits into
developfrom
feature/rework-details-screen

Conversation

@prachigarg19
Copy link
Copy Markdown
Collaborator

@prachigarg19 prachigarg19 commented Nov 17, 2022

Changes in this pull request:

  • combine Height and Width under one heading of “Measurements” in second to last row and include the measurement date for each remeasurements.
  • Plant Date should be moved in the last row before Registration Date.
  • include a space after the “,” in Coordinates.

@

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
planet-webapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 11:05AM (UTC)

Comment thread src/features/user/TreeMapper/components/PlantLocationPage.tsx Outdated
Comment thread src/features/user/TreeMapper/components/PlantLocationPage.tsx Outdated
@prachigarg19 prachigarg19 marked this pull request as draft November 19, 2022 14:30
<p className={styles.title}>{t('date')}</p>
{location.history?.map((h, index) => (
<div className={styles.value} key={index}>
{moment(h?.created).format('DD-MM-YYYY')}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have some date formatting at

export default function formatDate(dateString: any) {

<p className={styles.title}>{t('date')}</p>
{location.history?.map((h, index) => (
<div className={styles.value} key={index}>
{formatDate(h?.created)}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but I would give the creation date a little more horizontal space to avoid breaking the date into two lines:

Bildschirm­foto 2022-12-18 um 13 19 39

@norbertschuler
Copy link
Copy Markdown
Collaborator

Please change the description default value to something describing this PR.

@sagararyal
Copy link
Copy Markdown
Member

Screenshot 2023-02-22 at 3 23 25 PM

@sagararyal sagararyal merged commit 7056738 into develop Feb 23, 2023
@sagararyal sagararyal deleted the feature/rework-details-screen branch February 23, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants