Release cleanup#1601
Merged
Merged
Conversation
> as namespaces do not need to exported/imported
- due to unused state variable `open` - unused context parameter `selectedSite`
- explicitly define return types for functional component `Details` - component was implicitly returning `JSX.Element` or `false` - refactor code to return `ReactElement` | `null`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
📝 Changed routes:
Commit 217c2f1 (https://planet-webapp-6uszqpzps-planetapp.vercel.app). |
![Screenshot of /[p]](https://images.weserv.nl?url=https://sjc.microlink.io/v4qEYcm6KC-GZXR6eK3qbxzpY-gCdqTw_PWwLyuCNe--1-1ElH39FtWHMECXOTfTje25HsBGbx6zsQ7Jh63N7w.png&w=600)
Shreyaschorge
approved these changes
Nov 2, 2022
| const [internalCurrencyCode, setInternalCurrencyCode] = React.useState(''); | ||
| const [internalLanguage, setInternalLanguage] = React.useState(''); | ||
| const [open, setOpen] = React.useState(false); | ||
| const [_open, setOpen] = React.useState(false); |
Contributor
There was a problem hiding this comment.
If _open is not being used then it can be removed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup for release of 2nd Nov 22
Detailsto remove TS error and explicitly return typeReactElementornull