Dashboard maintenance refactor#1585
Merged
Merged
Conversation
- update BulkCodeSteps to string values - set up tabConfig and enable/disable conditions - use common CenteredContainer - allow BulkCodesForm to occupy full container width
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- along with 77126b5 - uses a common InlineFormDisplayGroup where needed - fix alignment in groups not containing only text fields with type prop - update min text field width to 180px
mohitb35
force-pushed
the
feature/dashboard-maintenance-refactor
branch
from
2b87fad to
ec86c7b
Compare
- BulkCodes - ManagePayouts - PlanetCash - DonationLinkForm - also refactor DonationLinkForm to remove formButtonContainer - remove unused BulkCodesForm component and formButtonContainer class
mohitb35
force-pushed
the
feature/dashboard-maintenance-refactor
branch
from
b93fc23 to
ecf621c
Compare
mohitb35
force-pushed
the
feature/dashboard-maintenance-refactor
branch
from
ef3e6e2 to
aa15b05
Compare
- in SingleColumnView, Bulk Codes, Manage Payouts - NoBankAccount, PlanetCash - NoPlanetCashAccount
mohitb35
force-pushed
the
feature/dashboard-maintenance-refactor
branch
from
aa15b05 to
2f59350
Compare
- wraps header content placed above a `<form>` within a common container - remove unrequired `formTitle` styles from `StyledForm`
- reason > lighter API call - also update types/interfaces a. rename `APISingleProject` > `MapSingleProject` to reflect API resp. b. use `MapSingleProject` instead of `SingleProject` in DonationLinkForm c. remove unused APISingleProject/SingleProject interfaces d. move `MapSingleProject` to project type file
sunilsabatp
approved these changes
Nov 2, 2022
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors recently introduced features in the dashboard to remove code duplication / create reusable components / clean up code where possible. These features include
Changes
TabbedViewInlineFormDisplayGroupdefinitions (or similar elements)StyledFormCenteredContainerwhere possibleFormHeaderFixes #1580