Skip to content

Center map#1570

Merged
mariahosfeld merged 6 commits into
developfrom
feature/center-map
Oct 4, 2022
Merged

Center map#1570
mariahosfeld merged 6 commits into
developfrom
feature/center-map

Conversation

@prachigarg19

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented Sep 19, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 6:05PM (UTC)

@mariahosfeld

Copy link
Copy Markdown
Contributor

Tested the functionality, works for me as expected.

@mohitb35 mohitb35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prachigarg19 I've taken a look and suggested some minor changes.

Also, the new viewport gets lost if the user goes to a single project page and comes back (the map no longer remains centered in this case).

Comment thread src/features/projects/components/ProjectsMap.tsx
@mariahosfeld

Copy link
Copy Markdown
Contributor

I checked again, the project_list=false context is lost when going back from a single project view.

@mariahosfeld

Copy link
Copy Markdown
Contributor

Functioniality now works for me.

@norbertschuler norbertschuler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but make the map even more Europe centered as before as the map always get reseted to these coordinates when hiding or showing projects even if you currently looking at another spot of the world.

@mariahosfeld mariahosfeld merged commit 8ef4028 into develop Oct 4, 2022
@mariahosfeld mariahosfeld deleted the feature/center-map branch October 4, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants