Feature/manage payouts#1552
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
66a010f to
5e32bd6
Compare
- includes translations, basic controlled inputs
24e6be3 to
7627497
Compare
- includes translations - updates translations for PayoutScheduleForm as well
6483890 to
de99c36
Compare
- add constants for PaymentFrequencies and PayoutCurrency - add explicit type declaration while declaring currencyOptions
This comment was marked as duplicate.
This comment was marked as duplicate.
- use common CenteredContainer component around non list tab contents - update font size for account details grid
- allows user to change account currency to default while editing a/c
| const [stepToRender, setStepToRender] = useState<string | number | false>( | ||
| false |
There was a problem hiding this comment.
here why did you used false as a type for stepToRender instead of Boolean as a type?
There was a problem hiding this comment.
As per the MUI documentation, when no tab is selected, we need to set the value attribute for Tabs component to false. So stepToRender can take false as a value. However, true is not a valid value, so I've not used type boolean
| style={{ width: '175px', marginTop: '20px', marginLeft: '10px' }} | ||
| > |
There was a problem hiding this comment.
avoid inline styles instead create a separate class for it
|
@mohitb35 whenever I am selecting payment frequency in payout schedule I am getting 400 payload |
This is fixed now. |
|
Functionality looks good to me |

![Screenshot of /profile/payouts/edit-bank-details/[id]](https://images.weserv.nl?url=https://sjc.microlink.io/D4_on852ucSiXRXvEGd8pXrvv5gakXsMjAT5zM-BfrCV3BOvP85WiFr99SIJ1AD2Y1wQ8uGBQNsFsKgow8brlQ.png&w=600)



Changes in this pull request:
Minor API changes are currently pending. Specifically:
routingNumberis to be an optional field while saving bank details. Currently the API responds with an error if this is not provided.holderTypeis an optional parameter while saving bank details and will not be sent from the front end. Currently the API responds with an error if this is not provided, and so we are always sending a hardcoded value ofindividual.3. We are currently not sending a clean request object while saving bank details i.e. empty fields are being sent as""instead ofnull. This may change (a function already exists to clean the request object). - NOT TO BE DONE SO THAT USERS CAN REMOVE OPTIONAL FORM VALUES DURING EDIT