add ecosystem metadata for project overview#1484
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Shreyaschorge
previously requested changes
May 25, 2022
Contributor
|
In my tests the functionality works now. |
sagararyal
reviewed
May 27, 2022
| newMonth.isSet = !month.isSet; | ||
| const plantingSeasonsNew = plantingSeasons; | ||
| plantingSeasonsNew[id] = newMonth; | ||
| plantingSeasonsNew[id - 1] = newMonth; |
Member
There was a problem hiding this comment.
bad practice, never add things like xyz_new. it gets old quickly.
tejassonar
reviewed
May 29, 2022
…com/Plant-for-the-Planet-org/planet-webapp into feature/conservation_manageProjects
sunilsabatp
dismissed
Shreyaschorge’s stale review
it is an constant variable , and not that much relevant , to change that variable name with meaningful one
Contributor
|
@sunilsabatp Please add spaces in between. It just looks a bit off.
|
Shreyaschorge
approved these changes
May 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
1.eslint error
steps to check : type npx eslint . terminal
2.planting season field loosing data after reload
steps: 1.go to manage project and select one project (activity season for conservation page)
2.click on edit button for that single project
3.then go to detail-analysis form
4.then reload the page
5.check the planting season field whether it is losing it's data or not
3.project sites getting 400
steps:1.go to manage project and select one project
2.click on edit button for that single project
3.then go to project sites form
4.click on edit of existing project using that pencil mark
5.modal will open then don't do any thing
6.click the back button of modal
7.then save the project form using save and continue button
8.check whether you are getting validation error
4.added ecosystem label for single conservation project
steps: 1. go to manage project
2.take one of conservation project
3.see the label of ecosystem on that project in the manage project
5.Application error fix
steps: click project button on side bar to visit manage project (profile/projects)
2.then check are you getting any Application error
6.error handling:
1.go to any form either (conservation or restoration )
2.generate 500 error to check the functionality of error handling
7.unit cost label for restoration project creation was wrong
steps: 1. go to manage project and click on Add project button
2.then select restoration project
3.check the field label (it should be Cost per unit)
8.planting season and activity season repopulating wrong data after submit
steps:1.go to manage project
2.click on edit for one of the project
3.go to detail analysis form
4. resubmit data for planting season and submit the form
5. go back to detail analysis check whether planting season showing same data or not
6. follow the same procedure for conservation form(activity season)