Skip to content

account fixes#1461

Merged
sagararyal merged 5 commits into
developfrom
feature/pagination_filter
Apr 13, 2022
Merged

account fixes#1461
sagararyal merged 5 commits into
developfrom
feature/pagination_filter

Conversation

@tejassonar
Copy link
Copy Markdown
Contributor

@tejassonar tejassonar commented Apr 7, 2022 •
edited by norbertschuler
Loading

  • added filter if available in paginated API calls
  • avoid crash for null donor certificate

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/planetapp/planet-webapp/8LPpbeKxqXP2rdJ3hwRm6gSFarph
✅ Preview: https://planet-webapp-git-feature-paginationfilter-planetapp.vercel.app

@sagararyal
Copy link
Copy Markdown
Member

sagararyal commented Apr 7, 2022 •
edited
Loading

📝 Changed routes:

/profile/history
Screenshot of /profile/history
(view full size)

Commit b75e556 (https://planet-webapp-iayhv82ek-planetapp.vercel.app).

ankitecd
ankitecd approved these changes Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitecd ankitecd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@norbertschuler norbertschuler changed the title added filter if available in paginated API calls account fixes Apr 9, 2022
norbertschuler
norbertschuler reviewed Apr 9, 2022
View reviewed changes
Comment thread src/features/user/Account/components/AccountRecord.tsx
Comment on lines +59 to +68
{(record?.details?.donorCertificate ||
record?.details?.taxDeductibleReceipt ||
record?.details?.giftCertificate) && (
<>
<div className={styles.title}>{t('downloads')}</div>
<div className={styles.detailGrid}>
<Certificates recordDetails={record.details} />
</div>
</>
)}
Copy link
Copy Markdown
Collaborator

@norbertschuler norbertschuler Apr 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this software with the production backend as I have a conversation donation done there. Unfortunately this of course can not solve the issue if the backend returns a link to a certificate, e.g. https://app.plant-for-the-planet.org/certificate/BYYRKSKQ4891 which then result into an error TCPDF ERROR: [Image] Unable to get the size of the image: /tmp/certyLJv9q.

Bildschirmfoto 2022-04-09 um 11 14 49

@norbertschuler
Copy link
Copy Markdown
Collaborator

norbertschuler commented Apr 9, 2022 •
edited
Loading

Backend filters still do not seem to work correctly (tested on staging and production), e.g. filtering for "failed" does not show any result in the API call besides retrieving all items contains an item with status: "failed" (compare #1239):

Bildschirmfoto 2022-04-09 um 11 28 35

I think we should clarify with the backend team once more if these filters are correctly defined:

Bildschirmfoto 2022-04-09 um 11 31 38

@sagararyal sagararyal merged commit dc4f8fc into develop Apr 13, 2022
@sagararyal sagararyal deleted the feature/pagination_filter branch April 13, 2022 09:14
@mariahosfeld mariahosfeld mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norbertschuler norbertschuler norbertschuler approved these changes

+1 more reviewer

@ankitecd ankitecd ankitecd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejassonar @sagararyal @norbertschuler @ankitecd