Skip to content

edited terms & condition feature#1455

Merged
sagararyal merged 11 commits into
developfrom
feature/TermsAndCondition
Apr 4, 2022
Merged

edited terms & condition feature#1455
sagararyal merged 11 commits into
developfrom
feature/TermsAndCondition

Conversation

@sunilsabatp
Copy link
Copy Markdown
Contributor

@sunilsabatp sunilsabatp commented Mar 22, 2022

Fixes #

Changes in this pull request:

  • added feature of Terms and condition system on the complete sign up page
    -created a new state for term and condition
    -the user cannot create account without accepting terms and condition

@sunilsabatp sunilsabatp requested a review from tejassonar March 22, 2022 05:39
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/planetapp/planet-webapp/HkFwCrDVpMYNM273T12ftwbVYQ4j
✅ Preview: https://planet-webapp-git-feature-termsandcondition-planetapp.vercel.app

@mariahosfeld
Copy link
Copy Markdown
Contributor

@sunilsabatp Please also include the German translations of the new text components, at the moment it is only in English (same for the error message, not included in the screenshot).
translation_problem

Comment thread public/static/locales/en/editProfile.json Outdated
@norbertschuler
Copy link
Copy Markdown
Collaborator

norbertschuler commented Mar 26, 2022

  • The red error message already gets displayed when you switch e.g. the private account checkbox:

160249722-4e59cfa7-40fd-40aa-bcd7-eb141e3ed011

@norbertschuler norbertschuler self-requested a review March 26, 2022 17:05
@norbertschuler
Copy link
Copy Markdown
Collaborator

norbertschuler commented Mar 26, 2022

  • And after registration a red error popped up - the API call POST https://app-staging.plant-for-the-planet.org/app/profile to register the user replied with an 400 error not doing the registration correctly, but the frontend also does not react on the 400 error correctly as well:
{"code":400,"message":"Validation Failed","errors":{"errors":
   ["Dieses Formular sollte keine zus\u00e4tzlichen Felder enthalten.","","Extra fields: terms"],
"children":{"type":{},"oAuthAccessToken":{},"name":{},"gender":{},"title":{},"firstname":{},"lastname":{},"address":{},"zipCode":{},"city":{},"country":{},"isPrivate":{},"getNews":{},"currency":{},"locale":{},"url":{},"urlText":{},"bio":{},"target":{},"imageFile":{},"tin":{},"mayContact":{}}}}

160249792-699bdeed-8f3a-4313-98c2-83e7b4a4897d

Copy link
Copy Markdown
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the errors first (either we need backend support for the new terms field or we should not send it with the API request, but then a hack could register without accepting the terms).

@sagararyal sagararyal self-requested a review April 1, 2022 13:28
Copy link
Copy Markdown
Member

@sagararyal sagararyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement interpolation of translation key, so multiple translation keys aren't added for one sentence.

Comment thread src/features/user/CompleteSignup/index.tsx Outdated
@norbertschuler
Copy link
Copy Markdown
Collaborator

norbertschuler commented Apr 2, 2022

Please implement interpolation of translation key, so multiple translation keys aren't added for one sentence.

@sagararyal I added a usage of the Trans component from react-i18next: https://react.i18next.com/latest/trans-component.

@sagararyal sagararyal merged commit c402ffb into develop Apr 4, 2022
@sagararyal sagararyal deleted the feature/TermsAndCondition branch April 4, 2022 10:42
@mariahosfeld mariahosfeld mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants