Make the backend segmenter package deploy as a Docker container #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanjli
changed the title
This was referenced Jan 17, 2024
|
I tested this as part of PlanktoScope/PlanktoScope#352 and was able to run a segmentation from start to finish, and I also confirmed that log files were being written as expected. So I consider this PR good enough to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress on PlanktoScope/PlanktoScope#326 by modifying the
core/apps/planktoscope/device-backend/processing/segmenterpackage to deliver the Python backend segmenter as a Docker container rather than assuming that it exists on the host.