Resolve Powershell CORE Issues

[jasonchester]

Bug Fixes

Use the pound / hash sign to indicate which GitHub issues this Pull Request fixes, if applicable.

• RU Display (Issue RU Verbose Output Display incorrect when run in PowerShell Core #168)
• Stored procedure debug logging
• Retry logic not working

@PlagueHO

---

This change is 

[codecov]

Codecov Report

Merging #180 into dev will decrease coverage by 3%.
The diff coverage is 20%.

@@        Coverage Diff         @@
##           dev   #180   +/-   ##
==================================
- Coverage   91%    87%   -4%     
==================================
  Files       12     12           
  Lines      893    896    +3     
==================================
- Hits       815    783   -32     
- Misses      78    113   +35

[PlagueHO]

Thanks @jasonchester - much appreciated as always!

I'm just finishing off the new Azure DevOps Release Pipeline (so that this can go out to the Gallery). So I'll review and merge this once the deploy process is working again (I broke it when I moved it to Azure DevOps). Should be solved over the next day or two.

[jasonchester]

Sounds good.

If you can validate that I was correct in changing$fatal = $true to $fatal = $false in utils.ps1. I assume it was a bug and not intentional but wanted to make sure. It definitely broke the retry policy on OSX.

Jason

[PlagueHO]

Getting onto the review first thing tomorrow! Thanks again @jasonchester

And yes, I think you're right - it does look like $fatal should have been $false! Great spotting!

[PlagueHO]

Good stuff @jasonchester - can you add some entries to the CHANGELOG.MD in the ## Unreleased section detailing the changes?

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jasonchester)

---

src/lib/utils.ps1, line 574 at r1 (raw file):

                    so determine is we should delay and try again or exit
                #>
                [System.Int32] $retryAfter = ($_.Exception.Response.Headers | Where-Object Key -eq 'x-ms-retry-after-ms').Value[0]

Can you use named parameters for Where-Object? E.g. `Where-Object -Property Key -eq 'x-ms-retry-after-ms')

---

src/lib/utils.ps1, line 601 at r1 (raw file):

                if($PSEdition -eq 'Core')
                {
                    #https://get-powershellblog.blogspot.com/2017/11/powershell-core-web-cmdlets-in-depth.html#L13

Can you add a space after the #? E.g # https://

[PlagueHO]

Thanks @jasonchester - awesome stuff and +++ appreciated. I'll release this week (just finishing the new release pipeline)

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved