Mesh notes changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 5, 2020 10:14
…tadata and userdata successfully
…e different objects. Can successfully pass in respective property values and set metadata with generated objects
…int in the mesh, save and proceed to create more notes, and/or save all notes, specifically note text and position of raycast (if available)
… been double clicked and a cube exists), and note text input field is not empty
…f notes is saved (setMetadata is successful)
…s, ie. getMetadata
…tpoint detected, and when edit button is selected, display note text in text box which can then be edited. Also, when delete button is pressed, the node is removed from the scene but the metadata is not changed
…he place metadata in firebase, as well as from the scene
…metadata in firebase
…does not hit an existing object, as well as clearing the input bar. Additonal comments added
…ote array remains and the new note object is added to the note array in firebase
…gain. Now, all of the old noteCubes will be removed, and the noteCubes will be added to the scene again.
…d trying to edit/delete that new note
…scene properly. When clicking the load button, the delete button, and the save all notes button, all notes will be removed from the scene and the new notes list will be added to the scene
…Expected behaviour: note text should be different
…d unnecessary local variables and referenced global variables instead
… edit a note right after saving the note
…ebase database is updated
… with sweetlalert popup which can be used to edit and save notes
… for when raycast hits placenoteMesh rather than a noteCube.
added 30 commits
April 2, 2020 10:43
…erties. Also, now prevents duplicate scene children from being loaded initially
…he mesh is rendered.
…instead of just note text
…d updated README.md
… note. Changed values related to camera zoom and note label placement
…moved when a point on the mesh is clicked
…arate scene children
…ed note, also slight UI updates
…d note selector placeholder and Font Awesome icons
… modal that appears when the settings icon is clicked. Additional UI fixes for icon positioning and z-index values
… id field that can be used for preventing duplicate scene children, editing, and deleting. This is useful for handling notes/rooms with the exact same text.
…es instead of overview images, added a row for room image navigation in the footer
…l scrolling for footer image row in the case of 5+ rooms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.