-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setPageMargin() does not work #22
Comments
Correct; MultiViewPager adjusts the margin itself for the mechanism through
which it centers pages. I would suggest specifying the margin through the
page's layout padding instead.
…On Thu, Aug 10, 2017, 18:28 Mario Velasco Casquero ***@***.***> wrote:
The margins set on setPageMargin() method are ignored and overrided by
MultiViewPager
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AARdY4Bv2yhzVTAX1ko7ci5Bowbg3OLvks5sWy-UgaJpZM4OzrEY>
.
|
Putting margin to the view is a trick to "solve" it, but that is no the correct way for two reasons:
|
Those are good points. However, I don't plan on updating this library as I instead recommend moving forward with LinearSnapHelper in conjunction with RecyclerViews. |
Thanks for the point out. Could I have animations with it? |
In the Readme there is a receference to LinearSnapHelper but I think it is not a good recplacement if you need any of the following requisites:
Maybe it not a good idea to point out to LinearSnapHelper from the Readme file without taking this into account |
The margins set on
setPageMargin()
method are ignored and overrided byMultiViewPager
The text was updated successfully, but these errors were encountered: