Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setPageMargin() does not work #22

Open
Mariovc opened this issue Aug 10, 2017 · 5 comments
Open

setPageMargin() does not work #22

Mariovc opened this issue Aug 10, 2017 · 5 comments

Comments

@Mariovc
Copy link

Mariovc commented Aug 10, 2017

The margins set on setPageMargin() method are ignored and overrided by MultiViewPager

@pflammertsma
Copy link
Collaborator

pflammertsma commented Aug 10, 2017 via email

@Mariovc
Copy link
Author

Mariovc commented Aug 10, 2017

Putting margin to the view is a trick to "solve" it, but that is no the correct way for two reasons:

  1. The method setPageMargin() doesn't work
  2. The margins will be animated together with the image. For example scaling the page x2 will create a double space between elements.

@pflammertsma
Copy link
Collaborator

Those are good points. However, I don't plan on updating this library as I instead recommend moving forward with LinearSnapHelper in conjunction with RecyclerViews.

@Mariovc
Copy link
Author

Mariovc commented Aug 16, 2017

Thanks for the point out. Could I have animations with it?

@Mariovc
Copy link
Author

Mariovc commented Aug 25, 2017

In the Readme there is a receference to LinearSnapHelper but I think it is not a good recplacement if you need any of the following requisites:

  • Animation when turning pages.
  • Bullet points. An indicator to show on which page you are.
  • Pages are turned one by one without acceleration.
  • Auto-scroll, pages are turned automatically.

Maybe it not a good idea to point out to LinearSnapHelper from the Readme file without taking this into account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants