Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdSt: add include for std.function in glslProgram. #3283

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

furby-tm
Copy link

@furby-tm furby-tm commented Sep 8, 2024

Without this change, the Swift/Clang compiler errors because it cannot find std.function used within hdSt's glslProgram.h header, in the alias declaration for PopulateDescriptorCallback.

Description of Change(s)

  • HdSt.GLSLProgram: Added a missing include for <functional>.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

* Without this, the swift/clang compiler errors because it cannot find std.function
  used within this header, in the alias declaration for PopulateDescriptorCallback.

Signed-off-by: furby™ <[email protected]>
@furby-tm
Copy link
Author

furby-tm commented Sep 8, 2024

(cc. @dgovil) - Would you like me to tag you in any Swift/ObjC related contributions? Just to keep in sync on possibly a large amount of similar revisions as Apple's fork.

@dgovil
Copy link
Collaborator

dgovil commented Sep 8, 2024

Yes please. That would be most appreciated.

This change looks good to me as well.

@jesschimein
Copy link

Filed as internal issue #USD-10098

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants