-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodesk: Text - Add the schema for SimpleText, together with the UnitTest #3258
base: dev
Are you sure you want to change the base?
Conversation
A new geometry schema SimpleText and its associated property schema TextStyle and TextLayout were defined in pxr/usd/usdText/schema.usda. Details of SimpleText and its style and layout schema were defined in the Text proposal. Unit tests of SimpleText were also included in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated code. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated file. Do not review.
Filed as internal issue #USD-10049 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change(s)
A new geometry schema SimpleText and its associated property schema TextStyle and TextLayout were defined in
pxr/usd/usdText/schema.usda
.Several schemas boilerplate files were generated by calling
usdGenSchema
onschema.usda
. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.Details of SimpleText and its style and layout schema were defined in the Text proposal. PR of the Text proposal can be accessed here. Feedback on the proposal is also appreciated.
Unit tests of SimpleText were also included in this PR.
This supersedes prior #3002. And is related to #3259
Fixes Issue(s)