Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Text - Add the schema for SimpleText, together with the UnitTest #3258

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

@erikaharrison-adsk erikaharrison-adsk commented Aug 30, 2024

Description of Change(s)

A new geometry schema SimpleText and its associated property schema TextStyle and TextLayout were defined in pxr/usd/usdText/schema.usda.

Several schemas boilerplate files were generated by calling usdGenSchema on schema.usda. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.

Details of SimpleText and its style and layout schema were defined in the Text proposal. PR of the Text proposal can be accessed here. Feedback on the proposal is also appreciated.

Unit tests of SimpleText were also included in this PR.

This supersedes prior #3002. And is related to #3259

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

A new geometry schema SimpleText and its associated property schema TextStyle
and TextLayout were defined in pxr/usd/usdText/schema.usda. Details of SimpleText
and its style and layout schema were defined in the Text proposal.

Unit tests of SimpleText were also included in this PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Copy link

@andy-shiue-autodesk andy-shiue-autodesk Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Copy link

@andy-shiue-autodesk andy-shiue-autodesk Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated code. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated file. Do not review.

@jesschimein
Copy link

Filed as internal issue #USD-10049

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants