You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As one validator may generate multiple distinct error kinds (for example, the usdGeom stage metadata checker validates both the upAxis and metersPerUnit field), the request is that errors get an identifier or name field that can uniquely group or categorize them for downstream post processing, filtering, and organization without relying on error prone matching of the error message string.
Steps to Reproduce
System Information (OS, Hardware)
Package Versions
Build Flags
The text was updated successfully, but these errors were encountered:
- Often a validator may result in multiple errors of different types,
but still being part of the same validator / validation testing task.
This identification can help categorize and probably provide some
filtering mechanism and client do not have to parse the error strings
to distinguish various error types from the same validator /
- ErrorIdentifier is constructed from the validator name which generated
the error and the error name.
- A Coding error is thrown if a client tries to call GetIdentifier
on an UsdValidationError which isn't generated via a call to
UsdValidator::Validate(), which is what sets the _validator on the
error.
- Also note if validator writer doesn't provide an error name for an
error, Error Identifier will be same as the name of the validator
which generated the error. validationt task.
- The Change here provides static tokens for all the validators
currently in our codebase: usd, usdGeom and usdShade.
- Updates tests and python wrappings to take care of the newly added
identifier
Additional things:
- Cleans many 80 column with violations
- Cleans many indentations to be uniform with surrounding code.
Fixes#3241
(Internal change: 2339935)
Description of Issue
See the discussion here for more information.
https://forum.aousd.org/t/identifiers-for-validation-errors
As one validator may generate multiple distinct error kinds (for example, the
usdGeom
stage metadata checker validates both theupAxis
andmetersPerUnit
field), the request is that errors get anidentifier
orname
field that can uniquely group or categorize them for downstream post processing, filtering, and organization without relying on error prone matching of the error message string.Steps to Reproduce
System Information (OS, Hardware)
Package Versions
Build Flags
The text was updated successfully, but these errors were encountered: