First pass at allowing user to move between TextBoxes with keyboard - Don't Merge #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am finally getting around to working on this and have figured out a slightly different and simpler approach. Closing this PR for now. I'll re-open another one once the branch is ready. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first pass at getting this to work. This PR is just to provide a place for people to comment and give feedback on the approach. Do not merge this!
This allows users to move between TextBox widgets by hitting enter. One problem I see with this approach is that whatever TextBox had previously captured input will try to un-capture after the next TextBox has started capturing. This results in a bunch of warnings printed to stdout.