Updated Accumulation sensor conversion in inches to account for API being in cm not mm #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Precipitation Accumulation. Typo in comment and changed conversion from mm to cm since API uses cm.
8 tasks
8 tasks
cloneofghosts
approved these changes
Nov 20, 2024
|
Looked through the PR and everything looks good to me. The conversion was changed to what it was due to #166 being opened saying that the accumulation was too high compared to the values displayed on MerrySky. Either way will merge this in and create a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Precipitation Accumulation conversion to inches. Changed conversion from mm to cm since API uses cm. Also, fixed typo in comment.