-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forecastio dependency & Fire Index value sensor #326
Conversation
@alexander0042 Just waiting on my comments in #297 to be addressed before this can be merged |
Sensor type/ constants/ daily
Ok, I think I got it working now! Forgot to copy over the config constants to add it, as well as the logic for the daily sensors and a type error. Great linting catches- pulling out the calc is a great idea. What did you mean by the comments though? |
@alexander0042 I mean the docstrings under the class/definitions Where it says |
Got ya! Just testing it now, but (with some help from ChatGPT) new version incoming |
I see you're having issue with the linter. If you have ruff installed you should just be able to run the lint script and it'll fix any fixable issues for you. I could also add it to the GitHub script to make things slightly easier. |
Okay looks like the linter passed but the formatter had issues committing even though it did afterwards. Will merge this to live. Want me to create the release or do you want to? |
Do you mind creating this one? I'm trying to get ruff working on my end, since it's about time I figured it out! |
Done. Should just be a case of installing ruff and then running the script in the scripts folder at least that's how I run it in VS Code. |
Removes the forecastio dependency from the integration and adds a fire index value sensor