Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forecastio dependency & Fire Index value sensor #326

Merged
merged 11 commits into from
Oct 8, 2024
Merged

Conversation

cloneofghosts
Copy link
Collaborator

Removes the forecastio dependency from the integration and adds a fire index value sensor

@cloneofghosts cloneofghosts added enhancement New feature or request bugfix A bug has been fixed labels Oct 8, 2024
@cloneofghosts
Copy link
Collaborator Author

@alexander0042 Just waiting on my comments in #297 to be addressed before this can be merged

@alexander0042
Copy link
Collaborator

Ok, I think I got it working now! Forgot to copy over the config constants to add it, as well as the logic for the daily sensors and a type error.

Great linting catches- pulling out the calc is a great idea. What did you mean by the comments though?

@alexander0042 alexander0042 marked this pull request as ready for review October 8, 2024 18:42
@alexander0042 alexander0042 self-requested a review as a code owner October 8, 2024 18:42
@cloneofghosts
Copy link
Collaborator Author

@alexander0042 I mean the docstrings under the class/definitions

Where it says """Mixin class to handle defining the proper __str__/__unicode__ methods in Python 2 or 3.""" in models.py

@alexander0042
Copy link
Collaborator

Got ya! Just testing it now, but (with some help from ChatGPT) new version incoming

@cloneofghosts
Copy link
Collaborator Author

I see you're having issue with the linter. If you have ruff installed you should just be able to run the lint script and it'll fix any fixable issues for you. I could also add it to the GitHub script to make things slightly easier.

@cloneofghosts
Copy link
Collaborator Author

Okay looks like the linter passed but the formatter had issues committing even though it did afterwards. Will merge this to live. Want me to create the release or do you want to?

@cloneofghosts cloneofghosts merged commit 2bc308f into master Oct 8, 2024
@alexander0042
Copy link
Collaborator

Do you mind creating this one? I'm trying to get ruff working on my end, since it's about time I figured it out!

@cloneofghosts cloneofghosts deleted the v1.6 branch October 8, 2024 19:29
@cloneofghosts
Copy link
Collaborator Author

Done. Should just be a case of installing ruff and then running the script in the scripts folder at least that's how I run it in VS Code.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix A bug has been fixed enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Migrate away from forecastio python library Fire index value sensor
2 participants