Code Quality/Updates Based on Blueprint #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for marking this as ready for review- I've been busy with some other stuff and getting time machine back online! I'm going to quickly double check that everything is still working on my end, but I absolutely love these changes. Everything is so much cleaner |
|
Ok, everything is looking good on my end! Can I say again how much I appreciate this stuff, your work here (and all the other updates you've been doing) is absolutely invaluable, and is so vital for this project! |
|
You're welcome! I figured that you're likely busy with version 2 of the API and the last two issues were pretty easy to I figured I could do it myself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had noticed that this repo was missing things from the integration blueprint repository so I added them back in. What I didn't realize is that most of these things were in the repo at one point but were removed early on. I can remove the devcontainer stuff if you'd prefer to not have them in this repo.
Part of the missing things was Ruff which is a python linter/formatter and I've also fixed all the lint issues that popped up as well. I can also remove this but I know you've mentioned that you'd like to submit this as an official repo at some point so I'd recommend keeping it as HA uses linters in their repo. There is a way to get it to automatically fix any fixable changes by using a flag but it may be better to do it manually so it doesn't mess up any in-progress changes?
I've tested this on my system and I haven't encountered any issues and there's also a 1.4 beta you can install if you'd like to test it on your end.