Fix Precipitation Accumulation Units #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized last night while looking at the precipitation amounts that it was converting cm to mm by multiplying by 100 instead of 10. (I saw one day report 880mm of precipitation which is obviously incorrect). I was doing a quick test and noticed that none of the conversions were rounded and it leads to a crazy amount of decimal places. Maybe we can do the same thing as the percentages where if rounding is enabled it rounds the values to the nearest decimal otherwise 2/4 decimal places? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
precipAccumulationwas changed from cm to mm in #122 the conversion was never changed to convert from mm to inches. This PR changes the conversion and fixes #166Is precipAccumulation on hourly in mm or cm? If it's cm then we need to convert it to mm otherwise the conversion on hourly will be incorrect.Edit: Looked at the code and it's using a different variable.