Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Accumulation Forecast incorrect #285

Closed
7 tasks done
Hilo4321 opened this issue Aug 16, 2024 · 2 comments · Fixed by #286
Closed
7 tasks done

Liquid Accumulation Forecast incorrect #285

Hilo4321 opened this issue Aug 16, 2024 · 2 comments · Fixed by #286
Assignees
Labels
bug Something isn't working

Comments

@Hilo4321
Copy link

Describe the bug

Comparing expected liquid accumulation to other sources, this is not correct.

Nearly 2 inches of rain in a day would be quite an event for us here in Wisconsin.

I've seen this enough times to stop dismissing it and get it reported :)

nT1JsTNka7

Expected behavior

Display a reasonable liquid accumulation forecast.

Actual behavior

Displaying a value that isn't remotely realistic.

Home Assistant version

2024.7.3

Integration version

1.5.3

Other details

By the time I finished writing this report, the accumulation amount for "PirateWeather Liquid Accumulation 0d" dropped to .7008, which is still higher than any source I can find.

Troubleshooting steps

  • I have updated my Home Assistant installation to the latest version.
  • I have updated the Pirate Weather Integration to the latest version.
  • I have gone through the documentation before opening this issue.
  • I have searched this repository and API Repository to see if the issue has already been reported.
  • I have restarted my Home Assistant installation.
  • I have queried the API in my browser to confirm the issue is not with the API.
  • I have written an informative title.
@cloneofghosts
Copy link
Collaborator

Thanks for creating this issue. Whats happening here is the integration sends a request to get data from the API in scientific units which is then converted to your unit of choice.

When I was setting up the V2 specific sensors I missed converting those sensors from mm to inches. So the value you see there is in mm with inches as the unit. I have a PR ready to merge and will then shortly afterwards release a new version with the fix.

@cloneofghosts cloneofghosts moved this from Todo to In Progress in Pirate Weather Home Assistant Aug 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pirate Weather Home Assistant Aug 16, 2024
@Hilo4321
Copy link
Author

Cheers, I appreciate it! I knew it had to be something like that.

cloneofghosts referenced this issue Aug 20, 2024
Also corrects the datetime low temperature time to read the correct variable (low instead of min). The entity name is kept the same for compatibility
alexander0042 added a commit that referenced this issue Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants