Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zoho Campaigns] fix base url #14710

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

andrewjschuang
Copy link
Collaborator

@andrewjschuang andrewjschuang commented Nov 21, 2024

WHY

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated version numbers for various components to enhance compatibility and performance.
    • Improved base API URL flexibility in the Zoho Campaigns application.
  • Bug Fixes

    • Corrected a typographical error in the method name from listMailignLists to listMailingLists.

These updates ensure a smoother user experience and maintain the integrity of the application.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Nov 21, 2024 8:08pm
pipedream-docs ⬜️ Ignored (Inspect) Nov 21, 2024 8:08pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Nov 21, 2024 8:08pm

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces version updates across several files in the zoho_campaigns component. The version numbers for individual action files and the package itself have been incremented from "0.0.1" to "0.0.2" or "0.1.0" to "0.1.1". Additionally, a method in the zoho_campaigns.app.mjs file has been modified to use a dynamic base API URL instead of a hardcoded one, and a typographical error in a method name has been corrected.

Changes

File Change Summary
components/zoho_campaigns/actions/add-contact-to-mailing-list/add-contact-to-mailing-list.mjs Version updated from "0.0.1" to "0.0.2".
components/zoho_campaigns/actions/create-campaign/create-campaign.mjs Version updated from "0.0.1" to "0.0.2".
components/zoho_campaigns/package.json Version updated from "0.1.0" to "0.1.1".
components/zoho_campaigns/sources/new-campaign/new-campaign.mjs Version updated from "0.0.1" to "0.0.2".
components/zoho_campaigns/sources/new-contact/new-contact.mjs Version updated from "0.0.1" to "0.0.2".
components/zoho_campaigns/zoho_campaigns.app.mjs Method _getBaseUrl modified to use a dynamic base API URL; method name corrected from listMailignLists to listMailingLists.

Possibly related PRs

  • [ACTION] Loops.so - Add to Mailing List #14614 #14651: This PR enhances the Loops.so application by adding support for mailing lists, which is directly related to the changes made in the main PR that updates the add-contact-to-mailing-list.mjs file.
  • Loops.so new components #14226: This PR introduces new components for Loops.so, including actions related to contacts and mailing lists, which aligns with the updates in the main PR regarding mailing list functionality.
  • CustomJS: Add Run Puppoteer and HTML to PNG actions #14117: Although this PR focuses on CustomJS actions, it includes updates to the versioning of components that may indirectly relate to the overall structure of the application, similar to the version updates in the main PR.
  • Upgrade Supabase JS Client #14422: This PR upgrades the Supabase JS client, which may not be directly related but reflects ongoing improvements in the codebase, similar to the version updates in the main PR.
  • [Components] google_ad_manager - create report action component #14672: This PR introduces a new report creation action for Google Ad Manager, which, while not directly related, shows the ongoing development and enhancement of components in the system, akin to the updates in the main PR.

Suggested labels

bug, dependencies

Suggested reviewers

  • michelle0927

🐰 In the garden, changes bloom,
With version updates, there's more room.
From mailing lists to campaigns bright,
Our code grows stronger, taking flight!
A hop, a skip, a joyful cheer,
For every change, we hold so dear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@andrewjschuang andrewjschuang merged commit 1e4b7a6 into master Nov 21, 2024
10 of 11 checks passed
@andrewjschuang andrewjschuang deleted the zoho-campaigns/fix-base-url branch November 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant