Jira - Add pagination to labels async options

[jcortes]

WHY

Resolves #13806

Summary by CodeRabbit

• New Features
  • Updated the method for fetching options, now supporting asynchronous data retrieval for parent issues, labels, and issue types.
• Version Updates
  • Incremented version for the create issue component from 0.1.17 to 0.1.18.
  • Incremented version for the update issue component from 0.2.11 to 0.2.12.
  • Updated overall package version from 0.1.0 to 0.1.1, along with a significant dependency upgrade.

[vercel]

@jcortes is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes introduce significant modifications to the Jira component's issue handling, including the renaming and restructuring of the getResourcesInfo method to getOptions, enhancing its asynchronous data-fetching capabilities. Additionally, minor version updates were made to several files, reflecting potential bug fixes or improvements. The package.json file was also updated to reflect a new version and an upgraded dependency.

Changes

Files	Change Summary
components/jira/actions/common/issue.mjs	Renamed getResourcesInfo to getOptions, updated functionality for asynchronous data fetching.
components/jira/actions/create-issue/create-issue.mjs, components/jira/actions/update-issue/update-issue.mjs	Incremented version numbers from "0.1.17" to "0.1.18" and from "0.2.11" to "0.2.12" respectively.
components/jira/package.json	Updated version from 0.1.0 to 0.1.1 and dependency on @pipedream/platform from ^0.10.0 to ^3.0.1.

Assessment against linked issues

Objective	Addressed	Explanation
Add pagination to labels async options (#13806)	✅

🐰 In fields of green, I hop with glee,
New options await, as bright as can be!
With labels now paged, no limit in sight,
A world full of choices, oh what a delight!
Hooray for the changes, let’s dance and play,
For every small fix brings a brighter day! 🌼✨

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8191527 and 62ec946.

Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing (4)

• components/jira/actions/common/issue.mjs (2 hunks)
• components/jira/actions/create-issue/create-issue.mjs (1 hunks)
• components/jira/actions/update-issue/update-issue.mjs (1 hunks)
• components/jira/package.json (2 hunks)

Files skipped from review as they are similar to previous changes (3)

• components/jira/actions/create-issue/create-issue.mjs
• components/jira/actions/update-issue/update-issue.mjs
• components/jira/package.json

Additional comments not posted (2)

components/jira/actions/common/issue.mjs (2)

46-117: LGTM!

The changes to the getOptions method are well-structured and significantly improve the functionality by introducing asynchronous data fetching and pagination. The code follows a consistent pattern for each case and aligns with modern JavaScript practices.

The introduction of pagination is a notable enhancement that addresses the limitation of fetching only 100 labels at a time, which was a key objective of this PR.

The code changes are approved.

---

180-180: LGTM!

The change is consistent with the modifications made to the getOptions method and ensures that the options property is populated correctly.

The code change is approved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Sep 10, 2024 3:41pm

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between be99e3c and 72f18f0.

Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing (4)

• components/jira/actions/common/issue.mjs (2 hunks)
• components/jira/actions/create-issue/create-issue.mjs (1 hunks)
• components/jira/actions/update-issue/update-issue.mjs (1 hunks)
• components/jira/package.json (2 hunks)

Files skipped from review due to trivial changes (2)

• components/jira/actions/create-issue/create-issue.mjs
• components/jira/actions/update-issue/update-issue.mjs

Additional comments not posted (3)

components/jira/package.json (2)

3-3: Version Update Approved

The update from 0.1.0 to 0.1.1 correctly follows semantic versioning for minor changes and bug fixes.

---

13-13: Verify Dependency Update

The update of @pipedream/platform from ^0.10.0 to ^3.0.1 is significant and could introduce new features or breaking changes.

Run the following script to verify the compatibility of the updated dependency:

components/jira/actions/common/issue.mjs (1)

Line range hint 46-180: Significant Improvement in Data Fetching

The restructuring of the getResourcesInfo method to getOptions and the introduction of asynchronous data fetching and pagination are significant improvements. These changes align with modern JavaScript practices and the PR objectives to enhance label fetching capabilities.

Run the following script to verify the integration of the new method with existing code:

[GTFalcao]

LGTM!

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 72f18f0 and 090b93f.

Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing (4)

• components/jira/actions/common/issue.mjs (2 hunks)
• components/jira/actions/create-issue/create-issue.mjs (1 hunks)
• components/jira/actions/update-issue/update-issue.mjs (1 hunks)
• components/jira/package.json (2 hunks)

Files skipped from review as they are similar to previous changes (3)

• components/jira/actions/common/issue.mjs
• components/jira/actions/create-issue/create-issue.mjs
• components/jira/package.json

Additional comments not posted (3)

components/jira/actions/update-issue/update-issue.mjs (3)

11-11: Version update approved.

The version update from "0.2.11" to "0.2.12" is noted and approved, indicating a minor enhancement or bug fix.

---

Line range hint 1-100: Overall integration of changes confirmed.

The changes, including the version update and property reordering, are well-integrated within the existing code structure. The method implementations and property definitions appear consistent and coherent with the introduced changes.

---

15-29: Property reordering and modification approved, verify impact.

The reordering of projectId and issueIdOrKey along with the modification to make projectId optional is approved. However, verify the impact of these changes on the system, especially the optional marking of projectId.

Run the following script to verify the impact of making projectId optional:

[jcortes]

/approve