Update Slack - New Direct Message (Instant) trigger #12435

michelle0927 · 2024-06-14T15:55:11Z

Resolves #12428

Summary by CodeRabbit

New Features
- Added a new configuration option to ignore messages from yourself in Slack direct messages.
Bug Fixes
- Removed a console.log statement in the Slack new message in channels component.
Chores
- Updated Slack component version from 0.6.3 to 0.6.4.

vercel · 2024-06-14T15:55:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Visit Preview	Jun 17, 2024 3:33pm
pipedream-docs	⬜️ Ignored (Inspect)		Jun 17, 2024 3:33pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)		Jun 17, 2024 3:33pm

coderabbitai · 2024-06-14T15:55:18Z

Walkthrough

Recent updates focus on the Pipedream Slack components, specifically improving the New Direct Message (Instant) trigger by adding an optional feature to ignore messages sent to oneself. Version updates in both package.json and relevant source files reflect these changes. Additionally, minor logging cleanup occurs in the New Message in Channels trigger.

Changes

Files/Paths	Change Summary
`components/slack/package.json`	Updated version from `0.6.3` to `0.6.4`
`components/slack/sources/new-direct-message/new-direct-message.mjs`	Updated version, added `ignoreSelf` config option, adjusted event logic
`components/slack/sources/new-message-in-channels/new-message-in-channels.mjs`	Removed extraneous `console.log` statement in `handleMessage` method

Sequence Diagram(s)

Assessment against linked issues

Objective	Addressed	Explanation
Add optional boolean prop `Ignore Messages from Yourself` for New Direct Message trigger (#12428)	✅
Update version number for consistency (#12428)	✅
Remove debugging logs in New Message in Channels trigger (#12428)	✅

Poem

In the realm of Slack, a change so bright,
Ignored self-messages, a feature of light,
Logs are cleared, triggers refined,
With version bumps, all aligned.
Oh, what joy these updates bring,
As the codebirds in our minds sing!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fefc43c and 2e1ab1b.

Files selected for processing (3)

components/slack/package.json (1 hunks)
components/slack/sources/new-direct-message/new-direct-message.mjs (2 hunks)
components/slack/sources/new-message-in-channels/new-message-in-channels.mjs (1 hunks)

Files skipped from review due to trivial changes (2)

components/slack/package.json
components/slack/sources/new-message-in-channels/new-message-in-channels.mjs

Additional comments not posted (3)

components/slack/sources/new-direct-message/new-direct-message.mjs (3)

8-8: Version update from "1.0.17" to "1.0.18" is consistent with the PR's objectives.

30-36: The ignoreSelf property is well-defined with clear type, label, description, default value, and optional status.

44-44: Integration of the ignoreSelf condition in processEvent correctly implements the feature to ignore messages from the user themselves when enabled.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e1ab1b and 5bfa345.

Files selected for processing (1)

components/slack/sources/new-message-in-channels/new-message-in-channels.mjs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

components/slack/sources/new-message-in-channels/new-message-in-channels.mjs

andrewjschuang

LGTM

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5bfa345 and 56dd48a.

Files selected for processing (1)

components/slack/sources/new-direct-message/new-direct-message.mjs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

components/slack/sources/new-direct-message/new-direct-message.mjs

michelle0927 · 2024-06-18T14:38:59Z

/approve

add ignoreSelf prop

2e1ab1b

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

version

5bfa345

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

pipedream-component-development requested a review from GTFalcao June 14, 2024 16:18

andrewjschuang previously approved these changes Jun 14, 2024

View reviewed changes

michelle0927 added 2 commits June 17, 2024 11:33

do not emit message_changed events

f88ae1e

Merge remote-tracking branch 'origin/master' into issue-12428

56dd48a

michelle0927 dismissed andrewjschuang’s stale review via 56dd48a June 17, 2024 15:33

coderabbitai bot reviewed Jun 17, 2024

View reviewed changes

michelle0927 requested a review from andrewjschuang June 18, 2024 14:43

andrewjschuang approved these changes Jun 18, 2024

View reviewed changes

michelle0927 merged commit 60f61c1 into master Jun 18, 2024
11 checks passed

michelle0927 deleted the issue-12428 branch June 18, 2024 15:59

This was referenced Nov 5, 2024

Discord Bot - Source updates #14472

Merged

Slack - New User Added #14620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Slack - New Direct Message (Instant) trigger #12435

Update Slack - New Direct Message (Instant) trigger #12435

michelle0927 commented Jun 14, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 14, 2024 •

edited

Loading

coderabbitai bot commented Jun 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

andrewjschuang left a comment

coderabbitai bot left a comment

michelle0927 commented Jun 18, 2024

Update Slack - New Direct Message (Instant) trigger #12435

Update Slack - New Direct Message (Instant) trigger #12435

Conversation

michelle0927 commented Jun 14, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Jun 14, 2024 • edited Loading

coderabbitai bot commented Jun 14, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

andrewjschuang left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

michelle0927 commented Jun 18, 2024

michelle0927 commented Jun 14, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 14, 2024 •

edited

Loading

coderabbitai bot commented Jun 14, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)