fix(camera): disable camera when vacuum docked #472
Conversation
|
I saw that you wrote that you were a bit busy in the other open PR @PiotrMachowski, but is there someone else that could take a quick look at this one then? For me it's no rush but I think this would be a low hanging fruit that would prevent a lot of rate limiting for a lot of users that doesn't write their own automations. |
|
A friendly reminder @PiotrMachowski. We're probably a lot of users that get rate limited every time the vacuum gets stuck (since it keeps polling) and this should fix it. |
| @@ -30,7 +30,7 @@ action: | |||
| - condition: trigger | |||
| id: 0 | |||
| - service: | | |||
| {% if trigger.to_state.state in ["unavailable", "unknown", "docked"] %} | |||
| {% if trigger.to_state.state in ["unavailable", "unknown", "docked", "idle", "paused"] %} | |||
There was a problem hiding this comment.
@mival what do you mean by that? I think that's expected, e.g. the vacuum is idle but it may be charging (or it may not). I think the camera should be disabled when in that state anyhow.
There was a problem hiding this comment.
@dahlmo in my case (Roborock S5) when vacuum cleaner is docked the state is charging. So in my case I also need disable camera while state is charging
There was a problem hiding this comment.
Thanks, I updated the PR accordingly now.
|
I've been trying to get some eyes on this for quite a while now, anyone knows who I should |
|
@PiotrMachowski I have had this PR open for over a year now, since it's a one-liner (and in my opinion low risk, high reward) I hope you or one of the other maintainers can take a quick look. |
Closes #468.
Blueprint doesn't take the idle state into account, so you get rate limited by Xiaomi because of too frequent map fetching.