Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework makefile to ease packaging #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davide125
Copy link
Contributor

  • rename default target to qpress
  • add DESTDIR support
  • add clean target
  • allow overriding the compiler and the build flags

@PierreLvx
Copy link
Owner

Hey 👋

Thanks for the PR!

Unfortunately, Mac OS 13 (and likely earlier versions too, but I didn't check) ships with a build of install which doesn't include the -D and -targuments.

Therefore, make errors as follows:

make install
install -D -p -m 0755 -t /usr/local/bin qpress
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [install] Error 64

I started this repo with Mac OS compatibility in mind, so I won't merge as-is for the moment.

@PierreLvx
Copy link
Owner

FYI: I have now added a clean target to the makefile.

On MacOS 14.6, install still does not have the required args to merge that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants