Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitchy compatibility with Crawl #18

Open
PieKing1215 opened this issue Sep 14, 2022 · 1 comment
Open

Glitchy compatibility with Crawl #18

PieKing1215 opened this issue Sep 14, 2022 · 1 comment
Labels
bug Something isn't working compatibility Related to another mod
Milestone
0.9.0

Comments

@PieKing1215
Copy link
Owner

https://www.curseforge.com/minecraft/mc-mods/crawl
While an inventory is open, you crawl at normal walking speed and if you have crawl set to toggle it toggles every tick when the key is pressed.
@PieKing1215 PieKing1215 added bug Something isn't working compatibility Related to another mod labels Sep 14, 2022
PieKing1215 added a commit that referenced this issue Oct 11, 2022
@PieKing1215
Improve handling of toggle keys
66e9e42 
Fixes toggle keys from other mods getting toggled every frame (gh-18)
@PieKing1215
Copy link
Owner Author

66e9e42 fixes the toggling every tick. The speed problem is fixed in Crawl's 1.19 version, and is otherwise caused by them using a mixin into KeyboardInput::tick which this mod completely bypasses (for now).

(Also note that GoProne doesn't use a ToggleKeyMapping for their toggle key, so the toggle problem was not present. As a result, their manual toggling code doesn't work inside inventories though, which will probably be something for InvMoveCompats to fix)

@PieKing1215 PieKing1215 added this to the 0.9.0 milestone Oct 21, 2024
PieKing1215 added a commit that referenced this issue Nov 9, 2024
@PieKing1215
Rework MovementMixin & manualTickMovement to duplicate less vanilla code
5d605e3 
Notably it actually calls KeyboardInput::tick instead of a copied version
Fixes gh-21
Fixes gh-18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compatibility Related to another mod
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@PieKing1215