Upgrade Error Prone 2.43.0 -> 2.44.0

documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java

@@ -85,7 +85,7 @@ private static ImmutableList<String> getSuppressionAnnotations(ClassTree tree) {
         .collect(toImmutableList());
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked" /* Type safety is validated, but a caller responsibility. */)
   private static <T extends AnnotationValue> T doCast(AnnotationValue value, Class<T> target) {
     verify(target.isInstance(value), "Value '%s' is not of type '%s'", value, target);
     return (T) value;

documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java

@@ -26,7 +26,7 @@
  */
 // XXX: Find a better name for this class; it doesn't generate documentation per se.
 final class DocumentationGeneratorTaskListener implements TaskListener {
-  @SuppressWarnings({"rawtypes", "unchecked"})
+  @SuppressWarnings({"rawtypes", "unchecked"} /* Unbounded wildcard type introduction is safe. */)
   private static final ImmutableList<Extractor<?>> EXTRACTORS =
       (ImmutableList)
           ImmutableList.copyOf(

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java

@@ -31,7 +31,7 @@ void before(
     }
 
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     void before(
         ObjectEnumerableAssert<?, E> enumAssert,
         @Matches(IsEmpty.class) Iterable<? extends E> emptyIterable) {

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java

@@ -169,7 +169,7 @@ OptionalLongAssert after(OptionalLong optional, long expected) {
 
   static final class ObjectEnumerableContainsOneElement<S, T extends S> {
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T element) {
       return Refaster.anyOf(
           iterAssert.containsAnyOf(element),
@@ -178,36 +178,36 @@ ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T e
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
       return iterAssert.contains(element);
     }
   }
 
   static final class ObjectEnumerableDoesNotContainOneElement<S, T extends S> {
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T element) {
       return iterAssert.doesNotContainSequence(element);
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
       return iterAssert.doesNotContain(element);
     }
   }
 
   static final class ObjectEnumerableContainsExactlyOneElement<S, T extends S> {
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> before(
         ObjectEnumerableAssert<?, S> iterAssert, @NotMatches(IsArray.class) T element) {
       return iterAssert.containsExactlyInAnyOrder(element);
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
       return iterAssert.containsExactly(element);
     }

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java

@@ -88,7 +88,7 @@ ImmutableSet<T> before(T e1) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1) {
       return Sets.immutableEnumSet(e1);
     }
@@ -110,7 +110,7 @@ ImmutableSet<T> before(T e1, T e2) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1, T e2) {
       return Sets.immutableEnumSet(e1, e2);
     }
@@ -133,7 +133,7 @@ ImmutableSet<T> before(T e1, T e2, T e3) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1, T e2, T e3) {
       return Sets.immutableEnumSet(e1, e2, e3);
     }
@@ -156,7 +156,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1, T e2, T e3, T e4) {
       return Sets.immutableEnumSet(e1, e2, e3, e4);
     }
@@ -179,7 +179,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4, T e5) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1, T e2, T e3, T e4, T e5) {
       return Sets.immutableEnumSet(e1, e2, e3, e4, e5);
     }
@@ -200,7 +200,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4, T e5, T e6) {
     }
 
     @AfterTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     ImmutableSet<T> after(T e1, T e2, T e3, T e4, T e5, T e6) {
       return Sets.immutableEnumSet(e1, e2, e3, e4, e5, e6);
     }

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java

@@ -67,7 +67,7 @@ Object after(InvocationOnMock invocation, int i) {
 
   static final class InvocationOnMockGetArgumentsWithTypeParameter<T> {
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Cast is presumed safe in matched context. */)
     T before(InvocationOnMock invocation, int i) {
       return Refaster.anyOf(
           invocation.getArgument(i, Refaster.<T>clazz()), (T) invocation.getArgument(i));

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java

@@ -2345,7 +2345,7 @@ StepVerifier after(StepVerifier stepVerifier) {
   /** Don't unnecessarily have {@link StepVerifier.Step} expect no elements. */
   static final class StepVerifierStepIdentity<T> {
     @BeforeTemplate
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked" /* Safe generic array type creation. */)
     StepVerifier.Step<T> before(
         StepVerifier.Step<T> step, @Matches(IsEmpty.class) Iterable<? extends T> iterable) {
       return Refaster.anyOf(

error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java

@@ -114,7 +114,7 @@ public static Supplier<Type> subOf(Supplier<Type> type) {
   }
 
   /**
-   * Creates an unbound wildcard type ({@code ?}).
+   * Creates an unbounded wildcard type ({@code ?}).
    *
    * @return A supplier which returns the described type.
    */

pom.xml

@@ -202,7 +202,7 @@
         <version.auto-value>1.11.0</version.auto-value>
         <version.error-prone>${version.error-prone-orig}</version.error-prone>
         <version.error-prone-fork>${version.error-prone-orig}-picnic-1</version.error-prone-fork>
-        <version.error-prone-orig>2.43.0</version.error-prone-orig>
+        <version.error-prone-orig>2.44.0</version.error-prone-orig>
         <version.jdk>21</version.jdk>
         <version.maven>3.9.11</version.maven>
         <version.pitest-git>2.2.5</version.pitest-git>