Introduce DequeRules Refaster rule collection

[Stephan202]

❗ This PR is on top of #1927. ❗

Suggested commit message:

Introduce `DequeRules` Refaster rule collection (#1946)

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[mohamedsamehsalah]

From my days of preparing for solving coding algorithms, that set of rules change a lot of the common terminology used 😄

But if I think about it, being more "explicit" about what each API does also makes things easier and alleviates some assumptions.

[mohamedsamehsalah]

Some people think of Deque as a replacement for Stack interface; wouldn't push (and pop) keywords be more relevant here? 🤔

[Stephan202]

Yes, that's a fair concern. My thinking is that the suggestions here will make the intent of the code clear in all cases, independently from (a) the specific combination of operations applied in a given context and (b) whether the user is familiar with stack operations.

It wouldn't surprise me if this change receives some pushback... let's see. 🤞

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[rickie]

/integration-test --> Build 🔴

[github-actions]

Suggested commit message:

Introduce `DequeRules` Refaster rule collection (#1946)

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[rickie]

Interesting, for prometheus-java-client we end up with a loop!

       r += item.g;
     }
     while (i < toIndex) {
-      samples.addLast(new Sample(sortedBuffer[i], 0));
+      samples.add(new Sample(sortedBuffer[i], 0));
       i++;
       n++;
     }

commit 3d0ba102bec88df0c27faf3e539084511408f44e
Author: Rick Ossendrijver <rick.ossendrijver@gmail.com>
Date:   Fri Nov 28 13:34:35 2025 +0100

    minor: Apply patches

diff --git a/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/CKMSQuantiles.java b/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/CKMSQuanti
les.java
index c16383f..ab99c21 100644
--- a/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/CKMSQuantiles.java
+++ b/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/CKMSQuantiles.java
@@ -110,7 +110,7 @@ final class CKMSQuantiles {
       r += item.g;
     }
     while (i < toIndex) {
-      samples.add(new Sample(sortedBuffer[i], 0));
+      samples.addLast(new Sample(sortedBuffer[i], 0));
       i++;
       n++;
     }

Didn't investigate further yet.

[rickie]

Was in meetings mostly so saw a nice opportunity for Windsurf 😄.

Root Cause Analysis
There are two conflicting rules:

`DequeAddLast` in `DequeRules.java`  (lines 31-41):

> Transforms: deque.add(element) → deque.addLast(element) for Deque<S> types

`ListAdd`  in `CollectionRules.java`  (lines 553-568):
> Transforms: list.addLast(element) → list.add(element) for List<S> types

The Problem:

LinkedList<T> implements both List<T> and Deque<T>

When `samples.add(...)` is called on a LinkedList:
The `DequeAddLast` rule matches and transforms it to `samples.addLast(...)`
The `ListAdd`  rule then matches and transforms it back to `samples.add(...)`

This creates an infinite loop of transformations

Created a new matcher. Think makes sense as there is this overlap for this specific method on both of the types.
Feel free to revert or decide to do otherwise :), as I said, mostly windsurf-ed it. :)

[github-actions]

Looks good. All 2 mutations in this change were killed.

class	surviving	killed
🎉tech.picnic.errorprone.refaster.matchers.IsList	0	2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

• Arcmutate licence valid until 2027-10-20 (yyyy/mm/dd) (non-commercial use only)

[rickie]

/integration-test -> build ✔️

[github-actions]

Looks good. All 2 mutations in this change were killed.

class	surviving	killed
🎉tech.picnic.errorprone.refaster.matchers.IsList	0	2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

• Arcmutate licence valid until 2027-10-20 (yyyy/mm/dd) (non-commercial use only)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stephan202]

I finally had a look at your changes; sorry for the delay @rickie. I rebased and added a small commit.

[Stephan202]

/integration-test -> build ✔️

[github-actions]

Looks good. All 2 mutations in this change were killed.

class	surviving	killed
🎉tech.picnic.errorprone.refaster.matchers.IsList	0	2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

• Arcmutate licence valid until 2027-10-20 (yyyy/mm/dd) (non-commercial use only)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud