Upgrade JUnit 5.13.4 -> 6.0.0 by Picnic-DevPla-Bot · Pull Request #1911 · PicnicSupermarket/error-prone-support

Picnic-DevPla-Bot · 2025-10-07T01:22:28Z

This PR contains the following updates:

Package	Type	Update	Change
JUnit (source)	import	major	`5.13.4` -> `6.0.0`

Release Notes

junit-team/junit-framework (JUnit)

`v6.0.0`: JUnit 6.0.0

JUnit 6.0.0 = Platform 6.0.0 + Jupiter 6.0.0 + Vintage 6.0.0

See Release Notes.

New Contributors

@2897robo made their first contribution in https://github.com/junit-team/junit-framework/pull/4525
@strangelookingnerd made their first contribution in https://github.com/junit-team/junit-framework/pull/4683
@eric6iese made their first contribution in https://github.com/junit-team/junit-framework/pull/4717
@raccoonback made their first contribution in https://github.com/junit-team/junit-framework/pull/4822
@currenjin made their first contribution in https://github.com/junit-team/junit-framework/pull/4823
@mehulimukherjee made their first contribution in https://github.com/junit-team/junit-framework/pull/4913
@lslonina made their first contribution in https://github.com/junit-team/junit-framework/pull/4629

Full Changelog: junit-team/junit-framework@r5.14.0...r6.0.0

`v5.14.0`: JUnit 5.14.0

JUnit 5.14.0 = Platform 1.14.0 + Jupiter 5.14.0 + Vintage 5.14.0

See Release Notes.

Full Changelog: junit-team/junit-framework@r5.13.4...r5.14.0

If you want to rebase/retry this PR, check this box

github-actions · 2025-10-07T01:24:54Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2025-10-07T01:24:59Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2025-10-07T01:25:16Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2025-10-11T12:38:27Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202

Rebased and added two commits. Suggested commit message:

Upgrade JUnit 5.13.4 -> 6.0.0 (#1911)

See:
- https://docs.junit.org/current/release-notes/
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0
- https://github.com/junit-team/junit-framework/releases/tag/r5.14.0
- https://github.com/junit-team/junit5/compare/r5.13.3...r6.0.0

Stephan202 · 2025-10-11T12:38:15Z

      "assertTimeoutPreemptively(Duration, ThrowingSupplier<T>)",
      "assertTimeoutPreemptively(Duration, ThrowingSupplier<T>, String)",
      "assertTimeoutPreemptively(Duration, ThrowingSupplier<T>, Supplier<String>)",
-      "assertTimeoutPreemptively(Duration, ThrowingSupplier<T>, Supplier<String>, TimeoutFailureFactory<E>)",


This method was annotated @API(status = INTERNAL, since = "5.9.1") and got dropped.

Stephan202 · 2025-10-11T12:40:51Z

  static final class AssertThatBooleanArrayWithFailMessageSupplierContainsExactly {
    @BeforeTemplate
-    void before(boolean[] actual, Supplier<String> message, boolean[] expected) {
+    void before(boolean[] actual, Supplier<@Nullable String> message, boolean[] expected) {
      assertArrayEquals(expected, actual, message);
    }

    @AfterTemplate
    @UseImportPolicy(STATIC_IMPORT_ALWAYS)
-    void after(boolean[] actual, Supplier<String> message, boolean[] expected) {
+    void after(boolean[] actual, Supplier<@Nullable String> message, boolean[] expected) {
      assertThat(actual).withFailMessage(message).containsExactly(expected);
    }
  }


JUnit now explicitly allows message suppliers to yield null. I validated that AssertJ supports this a well, so I annotated the @AfterTemplate method parameter types as well.

Stephan202 · 2025-10-11T12:52:50Z

Ugh: fix one thing, then other stuff pops up. The Reviewdog errors are likely addressed by #1915. The SonarCloud warnings look like false positives; will look into the best way to suppress those.

Picnic-DevPla-Bot · 2025-10-12T01:02:26Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

github-actions · 2025-10-25T12:39:31Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202 · 2025-10-25T13:07:34Z

I rebased and added one more commit to suppress the SonarCloud warnings.

github-actions · 2025-10-25T13:10:28Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

See: - https://docs.junit.org/current/release-notes/ - https://github.com/junit-team/junit-framework/releases/tag/r6.0.0 - https://github.com/junit-team/junit-framework/releases/tag/r5.14.0

github-actions · 2025-10-27T12:46:18Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

sonarqubecloud · 2025-10-27T12:46:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-11-16T14:06:19Z

Suggested commit message:

Upgrade JUnit 5 5.13.4 -> 6.0.0 (#1911)

See:
- https://docs.junit.org/6.0.0/release-notes/
- https://github.com/junit-team/junit-framework/releases/tag/r5.14.0-RC1
- https://github.com/junit-team/junit-framework/releases/tag/r5.14.0
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0-M1
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0-M2
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0-RC1
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0-RC2
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0-RC3
- https://github.com/junit-team/junit-framework/releases/tag/r6.0.0
- https://github.com/junit-team/junit-framework/compare/r5.13.4...r6.0.0

Picnic-DevPla-Bot added the dependencies label Oct 7, 2025

Picnic-DevPla-Bot requested review from Stephan202 and rickie October 7, 2025 01:22

Stephan202 mentioned this pull request Oct 11, 2025

Upgrade JUnit 5 5.13.4 -> 6.0.0 - autoclosed #1897

Closed

1 task

Stephan202 force-pushed the renovate/junit-6.x branch from 73ca30b to 1c76ce2 Compare October 11, 2025 12:36

Stephan202 added this to the 0.26.0 milestone Oct 11, 2025

Stephan202 approved these changes Oct 11, 2025

View reviewed changes

This was referenced Oct 11, 2025

Upgrade JUnit 5.13.4 -> 5.14.0 - autoclosed #1910

Closed

Run Reviewdog CI build with JDK 21 #1915

Merged

Stephan202 force-pushed the renovate/junit-6.x branch from 1c76ce2 to cfeb7ce Compare October 25, 2025 12:36

rickie approved these changes Oct 27, 2025

View reviewed changes

Picnic-DevPla-Bot and others added 4 commits October 27, 2025 13:43

Upgrade JUnit 5.13.4 -> 6.0.0

bedbd1a

See: - https://docs.junit.org/current/release-notes/ - https://github.com/junit-team/junit-framework/releases/tag/r6.0.0 - https://github.com/junit-team/junit-framework/releases/tag/r5.14.0

Add missing @Nullable annotations

4f7b1fc

Drop reference to removed method signature

cf8e34c

Suppress SonarCloud false positives

a86cd9e

rickie force-pushed the renovate/junit-6.x branch from 1135092 to a86cd9e Compare October 27, 2025 12:43

Stephan202 merged commit fea3df8 into master Oct 27, 2025
19 checks passed

Stephan202 deleted the renovate/junit-6.x branch October 27, 2025 13:10

Stephan202 mentioned this pull request Nov 16, 2025

Have OpenAI's Codex suggest commit messages #1984

Merged

Conversation

Picnic-DevPla-Bot commented Oct 7, 2025

Release Notes

v6.0.0: JUnit 6.0.0

New Contributors

v5.14.0: JUnit 5.14.0

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 11, 2025

Uh oh!

Stephan202 left a comment

Choose a reason for hiding this comment

Uh oh!

Stephan202 Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Stephan202 Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Stephan202 commented Oct 11, 2025

Uh oh!

Picnic-DevPla-Bot commented Oct 12, 2025

Edited/Blocked Notification

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

Stephan202 commented Oct 25, 2025

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

sonarqubecloud bot commented Oct 27, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

`v6.0.0`: JUnit 6.0.0

`v5.14.0`: JUnit 5.14.0

github-actions bot commented Nov 16, 2025 •

edited

Loading