Skip to content

Fix flake8 error in publisher example #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix flake8 error in publisher example #229

merged 1 commit into from
Jan 6, 2025

Conversation

@sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jan 6, 2025 •
edited
Loading

CI (on Rolling only) was showing this failure:

build/generate_parameter_module_example/pytest.xml: 3 tests, 0 errors, 1 failure, 1 skipped
- generate_parameter_module_example.test.test_flake8 test_flake8
  <<< failure message
    AssertionError: Found 1 code style errors / warnings:
      ./generate_parameter_module_example/minimal_publisher.py:39:1: CNL100 Class definition does not have a new line.
    assert 1 == 0
  >>>

@JafarAbdi JafarAbdi merged commit ee8a1f3 into main Jan 6, 2025
7 checks passed
@JafarAbdi JafarAbdi deleted the one-line-to-rule-them-all branch January 6, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophfroehlich christophfroehlich Awaiting requested review from christophfroehlich

@pac48 pac48 Awaiting requested review from pac48

1 more reviewer

@JafarAbdi JafarAbdi JafarAbdi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sea-bass @JafarAbdi