Skip to content

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Mar 20, 2024

This is... not pretty, but it seems to restore the functionality reported in #182 without breaking anything else.

@pac48 what do you think? More trouble than it's worth / should this just not be supported?

  __map_joints:
    weight: {
      type: double,
      default_value: 1.0,
      description: "map parameter without struct name",
      validation: {
        gt<>: [0.0],
      }
    }

it also supports nested!

  __map_joints:
    __map_dof_names:
      weight: {
        type: double,
        default_value: 1.0,
        description: "map parameter without struct name",
        validation: {
          gt<>: [0.0],
        }
      }

@sea-bass sea-bass requested a review from pac48 March 20, 2024 03:56
@sea-bass sea-bass self-assigned this Mar 20, 2024
Copy link
Contributor

@pac48 pac48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix. I noticed CI is failing in rolling, but that seems to be unrelated.

@pac48 pac48 merged commit edfeb82 into main Mar 23, 2024
@delete-merged-branch delete-merged-branch bot deleted the maps-without-struct-name branch March 23, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants