Skip to content

Conversation

@pac48
Copy link
Contributor

@pac48 pac48 commented Feb 25, 2024

This PR uses the python_install_dir macro to fix the install path of Python when using iron. Addresses #175

Signed-off-by: Paul Gesel <[email protected]>
@pac48 pac48 self-assigned this Feb 25, 2024
@Timple
Copy link
Contributor

Timple commented Feb 26, 2024

Yes, verified! This works on iron 🙂

@pac48
Copy link
Contributor Author

pac48 commented Feb 26, 2024

Yes, verified! This works on iron 🙂

@Timple Do you mind giving this an approving review?

Copy link
Contributor

@Timple Timple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was missing the approve button. But it's behind the 'review'. My bad.
Although it might not do much as I'm not a maintainer here 😄

@pac48 pac48 requested a review from sea-bass February 26, 2024 18:08
@pac48 pac48 merged commit 4b50b98 into main Feb 26, 2024
@delete-merged-branch delete-merged-branch bot deleted the pr-fix-python-install branch February 26, 2024 18:55
@Timple
Copy link
Contributor

Timple commented Mar 1, 2024

Awesome, thank you all.

Hopefully this makes it in the next iron release 🙂

@Timple Timple mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants