shared animation works and test, fixed warnings and test app

[KirkBushman]

Hi, this is the work I did to make BigImageViewer better support shared transition animations,
this is all working and tested, but this is only a starting point.

The problem, as described in #98, is that while the animation is running between two activities, the View switches the thumbnailView and the SSIV, causing stutters, or black frames, or an animation that does not run at all.

My suggestion is to have an additional parameter to only show the thumbnail for the transition and delay the main image loading, so we can trigger it later using listeners.

I've made those modifications, and a test environment, using two activities and it does work, while not breaking the others activities in the sample app.

I've added another listener for testing purposes, tell me if you want to keep it or not.

While working with the sample app, I reduced the number of warnings, moving harcoded strings in resources and other stuff, hope you don't mind. Bumped okhttp to the next minor too.

What do you think? would you do it in a different way?

Good night for now.

[Piasy]

Great work! Thanks for your contribution!

I'll check it today.

[KirkBushman]

I'm writing you here, probably should open an issue, would you consider moving this lib to java 8?
Now that desugaring is enabled by default, it makes it compatible to all previous bytecodes without using something like Retrolambda, so why miss all Java 8 features?

What do you think?

[Piasy]

I'm writing you here, probably should open an issue, would you consider moving this lib to java 8?
Now that desugaring is enabled by default, it makes it compatible to all previous bytecodes without using something like Retrolambda, so why miss all Java 8 features?

What do you think?

Do you mean we should change the library setting to compile it with Java 8? I don't understand what's the problem of compiling with Java 7?

[KirkBushman]

There is no problem with compiling with Java 7, but Java 8 is free, there is no restriction, so why not?

[KirkBushman]

Many libs are moving to Java 8 right now

[Piasy]

Okay I got it, but maybe some developers still stay at Java 7, if we bump to Java 8, they will be affected. Now that there is no problem with Java 7, I prefer stay at Java 7.

[KirkBushman]

ok

[Piasy]

Hi @KirkBushman , I did more test after merge this PR, I found some issues, and create a branch (shared_element_transition_bug) to reproduce them, could you please check out and fix them? Otherwise I can't publish this feature.

[KirkBushman]

Ok, I've did some testing and there are no problems with the standars ImageView or with using Glide or Fresco, I see only issues when using GlideImageViewFactory and FrescoImageViewFactory.
And that is caused by the fact that you load the images additionally inside the overridden ImageViewFactory.

We should think about moving that call out of there, since we want to have control on the whole process, also it does not make sense to me, that loading the image should be responsability of a View Factory, that should only provide the Views.

I've made a nice test environment for all this, I'm sending you a PR.