Skip to content

Feature/init frank #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
savageautomate merged 2 commits into from
Jun 4, 2020
Merged

Feature/init frank #10

savageautomate merged 2 commits into from
Jun 4, 2020

Conversation

@FDelporte
Copy link
Member

@FDelporte FDelporte commented Jun 3, 2020

needed to make minor modifications to be able to build

@FDelporte FDelporte requested a review from savageautomate June 3, 2020 21:08
@savageautomate
Copy link
Member

savageautomate commented Jun 4, 2020

Both forms of the following compile for me with no errors.

System.setProperty(org.slf4j.simple.SimpleLogger.DEFAULT_LOG_LEVEL_KEY, "INFO");
System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "INFO");

@savageautomate savageautomate merged commit 373b5aa into master Jun 4, 2020
@FDelporte
Copy link
Member Author

FDelporte commented Jun 4, 2020

Both forms of the following compile for me with no errors.

System.setProperty(org.slf4j.simple.SimpleLogger.DEFAULT_LOG_LEVEL_KEY, "INFO");
System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "INFO");

Strange indeed... But was a quick fix and the same form is now used everywhere

@FDelporte FDelporte deleted the feature/initFrank branch June 9, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savageautomate savageautomate Awaiting requested review from savageautomate

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FDelporte @savageautomate